From: John Wiegley <jwiegley@gmail.com>
To: David Edmondson <dme@dme.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] fix conv_lisp_to_sockaddr for AF_INET6 addresses
Date: Sun, 07 Feb 2016 12:52:02 -0500 [thread overview]
Message-ID: <m27figqugt.fsf@newartisans.com> (raw)
In-Reply-To: <m2twll6cxy.fsf@heart-of-gold.hh.sledj.net> (David Edmondson's message of "Sat, 06 Feb 2016 16:06:17 +0000")
>>>>> David Edmondson <dme@dme.org> writes:
> When trying to test Lars' async-dns changes I encountered memory corruption
> whenever the addresses returned for a host included IPv6 addresses. This
> turns out to be a bug in the mainline code which is just more likely to be
> tickled by the async-dns changes because they convert addresses to lisp
> objects whenever `make-network-process' is called (the current code doesn't
> do that).
Lars, it's the discovery of bugs like this that lead me to conclude two
things:
1. I'd like much more testing of this feature before we consider it for
release.
2. We need a suite of tests for this feature, because it makes a rather
fundamental change, and I'd like some coverage to ensure that others
working in similar areas won't break it in future.
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
next prev parent reply other threads:[~2016-02-07 17:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 16:06 [PATCH] fix conv_lisp_to_sockaddr for AF_INET6 addresses David Edmondson
2016-02-07 1:45 ` Lars Ingebrigtsen
2016-02-07 1:50 ` Lars Ingebrigtsen
2016-02-07 17:52 ` John Wiegley [this message]
2016-02-08 1:29 ` Lars Ingebrigtsen
2016-02-08 3:34 ` Eli Zaretskii
2016-02-08 3:59 ` Lars Ingebrigtsen
2016-02-08 4:01 ` Lars Ingebrigtsen
2016-02-08 4:07 ` Lars Ingebrigtsen
2016-02-08 7:03 ` Michael Albinus
2016-02-08 7:26 ` Lars Ingebrigtsen
2016-02-08 17:04 ` Eli Zaretskii
2016-02-08 23:17 ` Lars Ingebrigtsen
2016-02-09 19:13 ` Eli Zaretskii
2016-02-09 23:07 ` Lars Ingebrigtsen
2016-02-10 20:08 ` Eli Zaretskii
2016-02-10 20:31 ` Eli Zaretskii
2016-02-11 3:54 ` Lars Ingebrigtsen
2016-02-13 13:19 ` Eli Zaretskii
2016-02-08 3:43 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27figqugt.fsf@newartisans.com \
--to=jwiegley@gmail.com \
--cc=dme@dme.org \
--cc=emacs-devel@gnu.org \
--cc=johnw@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).