From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "John Wiegley" Newsgroups: gmane.emacs.devel Subject: Re: please review new branch feature/byte-unwind-protect Date: Tue, 23 Jan 2018 00:47:57 -0800 Message-ID: References: <87inbtnobf.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516697852 16509 195.159.176.226 (23 Jan 2018 08:57:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 23 Jan 2018 08:57:32 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (darwin) Cc: emacs-devel@gnu.org To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 23 09:57:27 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eduOV-00040o-9r for ged-emacs-devel@m.gmane.org; Tue, 23 Jan 2018 09:57:27 +0100 Original-Received: from localhost ([::1]:45943 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eduQV-0006Kx-LM for ged-emacs-devel@m.gmane.org; Tue, 23 Jan 2018 03:59:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eduLH-0001Td-F2 for emacs-devel@gnu.org; Tue, 23 Jan 2018 03:54:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eduLE-0008Lb-Cs for emacs-devel@gnu.org; Tue, 23 Jan 2018 03:54:07 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eduLE-0008LU-9V; Tue, 23 Jan 2018 03:54:04 -0500 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:57291) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1eduLD-0008EJ-Rk; Tue, 23 Jan 2018 03:54:04 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 1A6DF20A52; Tue, 23 Jan 2018 03:54:03 -0500 (EST) Original-Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Tue, 23 Jan 2018 03:54:03 -0500 X-ME-Sender: Original-Received: from localhost (76-234-69-149.lightspeed.frokca.sbcglobal.net [76.234.69.149]) by mail.messagingengine.com (Postfix) with ESMTPA id 6199B246D8; Tue, 23 Jan 2018 03:54:02 -0500 (EST) In-Reply-To: <87inbtnobf.fsf@tromey.com> (Tom Tromey's message of "Mon, 22 Jan 2018 22:20:36 -0700") Mail-Followup-To: Tom Tromey , emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222165 Archived-At: >>>>> "TT" == Tom Tromey writes: TT> I recently wrote a couple of patches to add two new bytecodes to Emacs. TT> These make it possible to compile unwind-protect without the need to TT> introduce a closure for the unwind forms. Hi Tom, Thanks for these changes. I just want to ask: what motivates them? Is it efficiency? Does it enable something you can't achieve otherwise? If the former, has it been measured? What is the corresponding cost of having this change? Thanks, -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2