From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrii Kolomoiets Newsgroups: gmane.emacs.devel Subject: Re: Feature branches review please Date: Thu, 05 Nov 2020 15:25:39 +0200 Message-ID: References: <20201104161200.tyeo2r5jibdahukb.ref@Ergus> <20201104161200.tyeo2r5jibdahukb@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11762"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 05 14:26:44 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kafHn-0002wh-S4 for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 14:26:43 +0100 Original-Received: from localhost ([::1]:37438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kafHm-0003uu-Ti for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 08:26:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kafGu-00033f-43 for emacs-devel@gnu.org; Thu, 05 Nov 2020 08:25:48 -0500 Original-Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:35010) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kafGr-0007ES-Mi for emacs-devel@gnu.org; Thu, 05 Nov 2020 08:25:47 -0500 Original-Received: by mail-lj1-x233.google.com with SMTP id 11so1570378ljf.2 for ; Thu, 05 Nov 2020 05:25:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Qs7ntqpHMQy+WUxtxgNZ9DCPpI8Wqi2WeCvJCJeXrY4=; b=r0w/Ejn9kHzh/CCWiPMxPNG9AVpOSsmT7m4r0h9JpPo5OLQjD56JpFcGn+XpcAi0xu onn6p+ytcLmH1dFOpAmOw3wuZNizpBXRD+jm3wTQ+qXQseIGVP+HDbrllvlv7sqmaBFo ZlOq/SueF0QSY2ayu8E5znFZ6g9IHyVxfI3J8fISB/aTfdj6roqMw3ZLIzNjDtzZGDdH CKM9O7Yt/Cl4rI1VIen/6japTCfa9HTBpmNr6IWRIRgWcYJt8qsb/zUMhYDPcBv2pEd+ 24xWxkNqjwFg1pRoMp0EO7UCP32NPyHNuqYZj095KWbaEgckEWsOFSIb/hhqK8/zyVFV QUOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Qs7ntqpHMQy+WUxtxgNZ9DCPpI8Wqi2WeCvJCJeXrY4=; b=O3sOqNd1SZuebBgZ9oWgZdfF5rmnIqp5PmzPiGMRmv9Yw3FneWa1icCO2F91P38QCa EkrXPNLGdR54RD+9owWKXv+Tz5AEGzieAUOU4G9dQgWGACrhxwwz1mH8dhXGz2gOoBFG tUjN0fIS3cxvf4smlYpF8UNXGGFptJ9kZvkJ1ZEFSddTewdDXVQNMhnlaRST+E3MdPqb XF74XjZDg56ODm+/4A68MOpBSOI/s73Er1rPV90g/Zdjv8jZ2hiKuk4TRzPamMryCIDi 6NhXPHZziPPlOCnHanEYERFubAOuvUOU3GHiuCZMVfMx9MlCB/6b9YkuEVgjlRjMHBHB EvVQ== X-Gm-Message-State: AOAM532SW2RFlLuFUJNBQsUK0hRDfDgqlHLq0ft8MY2wDdg9Afr5jEAG kpcxkwxgc3Xz4bTFFHy59ZIh2BbUDzQ= X-Google-Smtp-Source: ABdhPJzpDorzX+38J3vm93tFpJ57XeTxgVx3ZnrowMVcZw0r9kmzzBYtl9nCCdDLncNEsrzlqoYSNg== X-Received: by 2002:a2e:8750:: with SMTP id q16mr821205ljj.53.1604582742156; Thu, 05 Nov 2020 05:25:42 -0800 (PST) Original-Received: from muffinmac ([91.206.110.192]) by smtp.gmail.com with ESMTPSA id 16sm182577lfl.74.2020.11.05.05.25.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 05:25:41 -0800 (PST) In-Reply-To: <20201104161200.tyeo2r5jibdahukb@Ergus> (Ergus's message of "Wed, 4 Nov 2020 17:12:00 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::233; envelope-from=andreyk.mad@gmail.com; helo=mail-lj1-x233.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258716 Archived-At: Ergus writes: > The icomplete-vertical feature branch is pretty much ready, please if > any maintainer could give it a last review and tell me anything else > needed to merge into master? I'm not the maintainer, but can you please look into the following issue? Completions candidates not visible in the minibuffer-only frame. In 'emacs -Q': 1. Enable icomplete-mode: M-x icomplete-mode 2. Evaluate: (setq resize-mini-frames t) (setq icomplete-separator "\n") (setq icomplete-prospects-height 4) 3. M-x i Minibuffer now contains three completion candidates and ellipsis. Repeat the same steps in emacs -Q --eval "(setq default-frame-alist '((minibuffer . nil)))" Minibuffer now contains no completion candidates but only ellipsis. Thank you!