From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Bochannek Newsgroups: gmane.emacs.devel Subject: Re: master eaf224f: Repad the Face header in Gnus Date: Thu, 20 May 2021 16:23:18 -0700 Message-ID: References: <20200928120917.4097.80823@vcs0.savannah.gnu.org> <20200928120919.8AAC3209AC@vcs0.savannah.gnu.org> <873630bp5v.fsf@gnus.org> <87ft6z75hw.fsf@gnus.org> <87zh56wz8d.fsf@gnus.org> <87imbuq65p.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28803"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 21 05:12:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljvaA-0007Hg-KU for ged-emacs-devel@m.gmane-mx.org; Fri, 21 May 2021 05:12:14 +0200 Original-Received: from localhost ([::1]:56698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljva9-0006Ca-EU for ged-emacs-devel@m.gmane-mx.org; Thu, 20 May 2021 23:12:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljs1C-0006Z8-8c for emacs-devel@gnu.org; Thu, 20 May 2021 19:23:54 -0400 Original-Received: from ns.lapseofthought.com ([50.0.39.240]:47182 helo=mail.lapseofthought.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljs1A-0005vf-As for emacs-devel@gnu.org; Thu, 20 May 2021 19:23:53 -0400 Original-Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:7184:5aa9:b664:17a0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4FmQlV6Lr7z3pdmk; Thu, 20 May 2021 16:23:18 -0700 (PDT) In-Reply-To: <87imbuq65p.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 01 Oct 2020 18:09:54 +0200") Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com Received-SPF: pass client-ip=50.0.39.240; envelope-from=alex@bochannek.com; helo=mail.lapseofthought.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 20 May 2021 23:11:19 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269522 Archived-At: Lars Ingebrigtsen writes: > Alex Bochannek writes: > >> I went through a few years of Gnus newsgroups and other mailing lists to >> see if I can find Face headers that break. I found two people who posted >> invalid base 64 with embedded space characters. One case (a) was a >> simple issue of improper header folding. The other case (b) is an odd >> corner case where there is a single space right in a folded header field >> and the proper padding assigned as well. How about something like this >> to make case (a) display properly and not fail for case (b)? > > [...] > >> +(defcustom gnus-base64-repad-regexp "[A-Za-z0-9+/= ]" > > I don't think this is necessary -- nobody would want to customise > something like this. Follow-up on this from last year. I didn't get a chance to fully implement the functionality and I believe this code path is now disabled. I can pick it up again if you would like me to. If I can get some more test emails that would make it a bit easier to handle the corner cases. -- Alex.