From: David Engster <deng@randomsample.de>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: emacs-devel@gnu.org, ding@gnus.org
Subject: Re: no gnus registry new dependency on ert?
Date: Wed, 06 Apr 2011 17:03:50 +0200 [thread overview]
Message-ID: <m262qrzajt.fsf@randomsample.de> (raw)
In-Reply-To: <m2aag3zav2.fsf@randomsample.de> (David Engster's message of "Wed, 06 Apr 2011 16:57:05 +0200")
David Engster writes:
> Ted Zlatanov writes:
>> On Wed, 06 Apr 2011 15:28:07 +0200 David Engster <deng@randomsample.de> wrote:
>>
>> DE> It seems like putting (require 'ert) into an eval-when-compile is not
>
>> DE> sufficient. You have to require it unconditionally.
>>
>> DE> So maybe your first idea was The Right Thing To Do, meaning to use
>>
>> DE> (require 'ert nil t)
>>
>> DE> and then test for feature 'ert. Alternatively, you could use the current
>> DE> hack and put this require in there, too. But this is getting
>> DE> increasingly ugly...
>>
>> See the attached patch, which just adds (require 'ert nil t) *in
>> addition* to the defmacro hack. It seems to DTRT for me, let me know
>> what you think.
>
> Yes, that's what I meant with the latter suggestion. I'm not sure if
> this is the right way to solve this, but it works for me, too.
Addendum: Maybe the "real" solution is to have the tests in a separate
file, so that a (require 'registry) won't instantiate the ERT tests. I
can see why having the tests in the file itself can be convenient, but
usually, test-suites are separated from the actual code? Anyway, I don't
really have a strong opinion on this.
-David
next prev parent reply other threads:[~2011-04-06 15:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8762qs3swu.fsf@ericabrahamsen.net>
2011-04-06 10:03 ` no gnus registry new dependency on ert? Ted Zlatanov
[not found] ` <m24o6b667h.fsf@randomsample.de>
2011-04-06 10:54 ` Ted Zlatanov
2011-04-06 13:10 ` Ted Zlatanov
2011-04-06 13:28 ` David Engster
2011-04-06 14:26 ` Ted Zlatanov
2011-04-06 14:57 ` David Engster
2011-04-06 15:00 ` Ted Zlatanov
2011-04-06 15:03 ` David Engster [this message]
2011-04-06 15:51 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m262qrzajt.fsf@randomsample.de \
--to=deng@randomsample.de \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).