From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: James Nguyen Newsgroups: gmane.emacs.devel Subject: Re: Native line numbers, final testing Date: Sun, 02 Jul 2017 20:22:34 -0700 Message-ID: References: <83y3s9pm2a.fsf@gnu.org> <83zicmntaq.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499052176 7030 195.159.176.226 (3 Jul 2017 03:22:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 3 Jul 2017 03:22:56 +0000 (UTC) Cc: , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 03 05:22:52 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRrwk-0001BU-IM for ged-emacs-devel@m.gmane.org; Mon, 03 Jul 2017 05:22:46 +0200 Original-Received: from localhost ([::1]:60127 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRrwo-00088P-0x for ged-emacs-devel@m.gmane.org; Sun, 02 Jul 2017 23:22:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRrwh-000888-6s for emacs-devel@gnu.org; Sun, 02 Jul 2017 23:22:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRrwf-0000gs-Vz for emacs-devel@gnu.org; Sun, 02 Jul 2017 23:22:43 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39183) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dRrwb-0000dC-80; Sun, 02 Jul 2017 23:22:37 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 3333C20A3C; Sun, 2 Jul 2017 23:22:36 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute7.internal (MEProxy); Sun, 02 Jul 2017 23:22:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jojojames.com; h=cc:cc:content-type:date:from:in-reply-to:message-id :mime-version:references:subject:to:x-me-sender:x-me-sender :x-sasl-enc:x-sasl-enc; s=fm1; bh=aprz//+li1ATkfdmU/uqG6lP8brHPG FhJPFhmlJSFXw=; b=NWnlm5nGL9/JuW23S4lc/KXMCCMVatAj96snsu2ROOLbpV 9hNBjy0RLjEjUE0VizDn/0Vp1tUf3p37mJI5vPzYRrsvaLl4yfoXVN232++Np/3S 9VMtYd9Jh3B55VvVpt+6FLFseZflTRb2FJqOUia7t+icFQr8TWov5XZ2bno0feHm UPCVn/AH1kraKUJNHqHQe4WIXDDZdYEeZ3S3NSj5tn5edncnUfWkF0Db0D6Oj6Y7 J5bQ8pKyjLRCNZHo940hTuG6T7NqTfafZgBTAAmMeJYdHiQtRQ1ovIaTmmWOnjKs woMT78T8slP+RkzygFLfgk+6YIgPrDWuENQKktFA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=aprz//+li1ATkfdmU/ uqG6lP8brHPGFhJPFhmlJSFXw=; b=DEx55+oAb7/q3T+P56+8aBTxheqfm/aKhq 1h9IVLYtPV3NwS3st4VdXERG4iXK4GtsOsSfk+8JPRdrZdmAgCMoPm9TveBCIO1f TjOjwas9DMVDk2q0cuu600Fl6+3JMrQJih90NTs5u0e1+h8UftflkZi0qhYYbb39 xYAYLs5fdn9TZvaKw9elVlaYHbPvjT1bfJ87aGbgez9Q0HD8VhQwPoLIHS8klCxX rnlsq0+kjvB81zqDsnAgSYuNIMhFVtrgivuIxBYxML3CwValVZvw7WrVND3S7JIc PqMT0IiSWwVRL1AacB/oAulVRzjVaPk36lIm4vlMdcMTwEDOzOzg== X-ME-Sender: X-Sasl-enc: AaQAv5Nwjo9NzVON2H4jgtPGxV9rk2SvaZNx+rcnsbhN 1499052155 Original-Received: from localhost (c-73-231-191-86.hsd1.ca.comcast.net [73.231.191.86]) by mail.messagingengine.com (Postfix) with ESMTPA id CE13C7E070; Sun, 2 Jul 2017 23:22:35 -0400 (EDT) In-Reply-To: <83zicmntaq.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216127 Archived-At: Eli Zaretskii writes: > Are you sure this isn't a bug in evil-mode? Does this feature behave > correctly in a buffer with a non-nil line-prefix? > > Can you show a backtrace from the args out of range error? I haven't been keeping track of the line-prefix conversations around this feature but setting it and then trying to do same thing (as reported above) works in previous version of this line number branch. (setq line-prefix "1") 16d2695674 * @ Minor change in NEWS. ^ This combination works. Here's the trace on the latest commit. 4c9353a584 * scratch/line-numbers origin/scratch/line-numbers Debugger entered--Lisp error: (args-out-of-range 1) signal(args-out-of-range (1)) (condition-case err (let* ((range (evil-expand (point) (point) (quote line))) (beg (evil-range-beginning range)) (end (evil-range-end range)) (min (point-min)) (max (point-max))) (if (save-excursion (goto-char end) (bolp)) (progn (setq end (max beg (1- end))))) (if (and evil-move-cursor-back (not evil-move-beyond-eol) (not (evil-visual-state-p)) (not (evil-operator-state-p))) (progn (setq end (max beg (1- end))))) (save-restriction (let ((evil-restriction-stack (cons (cons ... ...) evil-restriction-stack))) (evil-narrow beg end) (let ((p (point))) (condition-case err (progn (condition-case err ... ... ...)) (error (if ... ...))))))) (error (setq this-command last-command) (signal (car err) (cdr err)))) (let ((evil-restriction-stack (cons (cons (point-min) (point-max)) evil-restriction-stack))) (evil-narrow (save-excursion (evil-backward-char (1+ (or count 1)) t t) (point)) (1+ (point))) (condition-case err (let* ((range (evil-expand (point) (point) (quote line))) (beg (evil-range-beginning range)) (end (evil-range-end range)) (min (point-min)) (max (point-max))) (if (save-excursion (goto-char end) (bolp)) (progn (setq end (max beg (1- end))))) (if (and evil-move-cursor-back (not evil-move-beyond-eol) (not (evil-visual-state-p)) (not (evil-operator-state-p))) (progn (setq end (max beg (1- end))))) (save-restriction (let ((evil-restriction-stack (cons ... evil-restriction-stack))) (evil-narrow beg end) (let ((p ...)) (condition-case err (progn ...) (error ...)))))) (error (setq this-comm and last-command) (signal (car err) (cdr err))))) (save-restriction (let ((evil-restriction-stack (cons (cons (point-min) (point-max)) evil-restriction-stack))) (evil-narrow (save-excursion (evil-backward-char (1+ (or count 1)) t t) (point)) (1+ (point))) (condition-case err (let* ((range (evil-expand (point) (point) (quote line))) (beg (evil-range-beginning range)) (end (evil-range-end range)) (min (point-min)) (max (point-max))) (if (save-excursion (goto-char end) (bolp)) (progn (setq end (max beg ...)))) (if (and evil-move-cursor-back (not evil-move-beyond-eol) (not (evil-visual-state-p)) (not (evil-operator-state-p))) (progn (setq end (max beg ...)))) (save-restriction (let ((evil-restriction-stack ...)) (evil-narrow beg end) (let (...) (condition-case err ... ...))))) (error (setq this-command last-command) (signal (car err) (cdr e rr)))))) (cond (noerror (condition-case nil (evil-backward-char count crosslines nil) (error nil))) ((not crosslines) (save-restriction (let ((evil-restriction-stack (cons (cons ... ...) evil-restriction-stack))) (evil-narrow (save-excursion (evil-backward-char (1+ ...) t t) (point)) (1+ (point))) (condition-case err (let* ((range ...) (beg ...) (end ...) (min ...) (max ...)) (if (save-excursion ... ...) (progn ...)) (if (and evil-move-cursor-back ... ... ...) (progn ...)) (save-restriction (let ... ... ...))) (error (setq this-command last-command) (signal (car err) (cdr err))))))) (t (let* ((countvar (or count 1)) (unitvar (if (< countvar 0) -1 1))) (catch (quote donevar) (let ((loopvar countvar)) (setq loopvar loopvar) (while (/= loopvar 0) (let (...) (backward-char) (if ... nil ...) (if ... . ..)) (if (> loopvar 0) (setq loopvar ...) (setq loopvar ...)) (setq loopvar loopvar)) loopvar))))) evil-backward-char(nil nil nil) funcall-interactively(evil-backward-char nil nil nil) call-interactively(evil-backward-char nil nil) command-execute(evil-backward-char)