From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS codegen Date: Sat, 15 Jun 2024 10:38:00 +0200 Message-ID: References: <877cetgqiz.fsf_-_@gmail.com> <87wmmsg2e4.fsf@gmail.com> <878qz8ezn4.fsf@gmail.com> <8734pfgb51.fsf@gmail.com> <86ikybyd2h.fsf@gnu.org> <87v82bebc6.fsf@gmail.com> <86wmmrwf86.fsf@gnu.org> <86r0czwdmc.fsf@gnu.org> <87jzire36a.fsf@gmail.com> <86plsiwxag.fsf@gnu.org> <868qz6wsvq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8434"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: eller.helmut@gmail.com, acorallo@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 15 10:38:45 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sIOvs-00022t-DS for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Jun 2024 10:38:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIOvI-0001fD-88; Sat, 15 Jun 2024 04:38:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIOvG-0001eG-QK for emacs-devel@gnu.org; Sat, 15 Jun 2024 04:38:06 -0400 Original-Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sIOvF-00074Z-0K; Sat, 15 Jun 2024 04:38:06 -0400 Original-Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a6f0e153eddso387731266b.0; Sat, 15 Jun 2024 01:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718440682; x=1719045482; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=icSQoj/iYX8+qAv7lB8igNDNBCyFkyfLS+/ryimubwk=; b=DB7ZULFi9Lwv/qK6X6fkNm0YaJ2zrV+IVMLODosjyrwJOIApAo0gOreOTaEIN6O/Te ZyVADLZ5P/PyKibQQZ3xxbls1yksKoOts+8c3zGbU/K26bK9k9iCIexlerEOdl8/Biwl o1DEWRS++07X0NamYZoGSmh0MHT5y5NPBEf6D1xP5fVfWF1VIE33ts4VuwPdi06cT8hb 86tEtwcOiDkSwfHHsz+io48jLiIHLoEdETH6NFM7giEt7e2BVJ4YeyhNyvnW2gnuw1iM BDTCSLcGZcImsslOxkH7K5or8WbqXk/GB6RxEQNfgFYgqSPUnh8SzSvEYErgEnXqhrES K+aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718440682; x=1719045482; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=icSQoj/iYX8+qAv7lB8igNDNBCyFkyfLS+/ryimubwk=; b=Vj4qL4XS4OitOgFlP8JPcqX/6+ElG8go7hdhrvUFcw5MLeE6U3f/I91ev6Ph+jUWHS ehJ4iMbMXmKgMb43hMUHNpBdxQXwnaFN49qWzv0r0AdimBD1GZclXn941Mn54UMnXrmp qf7EdvSbo6/zHD+vHGkN9eI2+0dnuSxhYD2m77eqyYgZGq13FkcEGGGyaaoep7cyKc00 SaUk+OSsiceoMsSM1Ed14z3hGh2tzG2N43ZGjf9gmv9+cKLQVrl59oGyNC2Ua07kCIvJ +11+L8h1AUnNqi4l6NyFB37ZGrCR90ssolKsTlvQRVT/pMnihzRWNBTNJKDaHnqZkTpT h0ng== X-Forwarded-Encrypted: i=1; AJvYcCXrATK+Xl6nLYuqUMEYFlDqVOfWhJ+LgIJGLAXhsxvOubWqUPk4zhOvfmXRGmecPHnWc/RsmIm2nGZtsLSbB74MQi3X+Kg3y654iaIpNaLRHGthYZcS X-Gm-Message-State: AOJu0Yz4iCfrRM686q/KtKvCq7i0uJn2nyPjmbBpoWpuka1R8qJaknW+ NmRX1kRVblapL3RByeRkyfi7PVhg4AbkdMirfxrySodGFhtsoJ9GfWUsBA== X-Google-Smtp-Source: AGHT+IHt6SGk62bhspqbuCN0DdsSYvrqWLh0w9IPtZqvejgXWPpr6ghDJwMcgRoxPhMhjHLqbu1W5A== X-Received: by 2002:a17:906:b2c8:b0:a6f:5723:fb11 with SMTP id a640c23a62f3a-a6f60dc50bcmr303591866b.58.1718440681965; Sat, 15 Jun 2024 01:38:01 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36be1.dip0.t-ipconnect.de. [217.227.107.225]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f56ecdcfbsm272129366b.109.2024.06.15.01.38.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jun 2024 01:38:01 -0700 (PDT) In-Reply-To: ("Gerd =?utf-8?Q?M=C3=B6llman?= =?utf-8?Q?n=22's?= message of "Sat, 15 Jun 2024 10:14:01 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320116 Archived-At: Gerd M=C3=B6llmann writes: > Eli Zaretskii writes: > >>> I still think we should first establish that that is indeed the problem. >>> Please see my other mail. >> >> Since you insist: I ifdef'ed away this: >> >> #if 0 >> /* Release the commit charge for the mapping. */ >> DWORD old_prot; >> (void) VirtualProtect (mem, size, PAGE_NOACCESS, &old_prot); >> #endif >> >> and, lo and behold, Emacs can now start without a problem. >> >> I hope this establishes the fact that we are still accessing memory >> from the "discarded" pdumper block. >> >> Now what? > > Thanks, and sorry, but that felt too much like guessing to me :-). I'll > see if I can come up with something equivalent on my system. Erm, I can't -=20 void dump_discard_mem (void *mem, size_t size) { #if VM_SUPPORTED =3D=3D VM_MS_WINDOWS /* Discard COWed pages. */ (void) VirtualFree (mem, size, MEM_DECOMMIT); /* Release the commit charge for the mapping. */ DWORD old_prot; (void) VirtualProtect (mem, size, PAGE_NOACCESS, &old_prot); #elif VM_SUPPORTED =3D=3D VM_POSIX # ifdef HAVE_POSIX_MADVISE /* Discard COWed pages. */ (void) posix_madvise (mem, size, POSIX_MADV_DONTNEED); # elif defined HAVE_MADVISE (void) madvise (mem, size, MADV_DONTNEED); #endif /* Release the commit charge for the mapping. */ (void) mprotect (mem, size, PROT_NONE); #endif } This does already an mprotect PROT_NONE on my system (no permissons at all), and there is nothing nore I can do. I can't munmap because that would write back the changes done by the reloc phase back to the .pdmp file.