From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: Forwording symbols Date: Tue, 18 Jun 2024 21:33:02 +0200 Message-ID: References: <87jziod6yc.fsf@gmail.com> <874j9rcuf6.fsf@gmail.com> <87y173bda9.fsf@gmail.com> <87plsfbcd5.fsf@gmail.com> <86cyoeqvfc.fsf@gnu.org> <87frta9pgf.fsf@gmail.com> <86v826p346.fsf@gnu.org> <86r0cup24x.fsf@gnu.org> <874j9q9l37.fsf@gmail.com> <86msnip0ul.fsf@gnu.org> <87tthq830y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30818"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 18 21:33:42 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJeaL-0007sd-FX for ged-emacs-devel@m.gmane-mx.org; Tue, 18 Jun 2024 21:33:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJeZp-0008IV-ES; Tue, 18 Jun 2024 15:33:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJeZn-0008I5-NR for emacs-devel@gnu.org; Tue, 18 Jun 2024 15:33:07 -0400 Original-Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJeZm-0000qW-2H; Tue, 18 Jun 2024 15:33:07 -0400 Original-Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-421cd1e5f93so41751005e9.0; Tue, 18 Jun 2024 12:33:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718739184; x=1719343984; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=19l7oYeQFFzpAk0yiSDcOfwWhwvL0xBD+rsOPvmf+Kw=; b=YUkFHeAyUptnG1b8vBk1UlAIK98BiNBtdXW208svyb+vsdI0keLcAL1C6WQWNIwqlK L1zV/tvfnAbvd278kwokeHLa2hk2oAr0fUxPvWehOp5qlwkUM4YEWE5nUV6qdPKDmoqU XI1YxNGw8LMXZ4irMUGnFqPETsh0YFCv8mTS1DqgjClPMlBwYTOzwD5eo1f7+som7oOg vfvMuW3DNvI5d7boAtfTtUlHM3ZkvxolbEswvLsayxytvzXPiDEAXx8olBaHzz7QrhXi 91et4doT9yJ723Lgn5pDN9GT3aEECGp420ZzrZVII9wSOc3cl56zDLZqj9dIxuQGybmJ cNRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718739184; x=1719343984; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=19l7oYeQFFzpAk0yiSDcOfwWhwvL0xBD+rsOPvmf+Kw=; b=I+v+5sa4KL/3AxuOTjjIaHDASPx8PlvKA5NPedliGBDmnyaWmJktsVrKHfBaol5Cex LmhYlxpADZ8o5c0Xs15B4KNrfL/VQp/34sTkyqUp98T++aGlDfz8dlEjELsjgrcOmF3l ObDN4B3l9gMyDFsWpN99gnPnVvbao1lRASSTPSO+5ARvLUOR/NdfifjPxgny107zFLwk oNpIR5US5Ut6uYUcd0g0+plvevBcW519GxfacqCsRps2Gphk0qWKhBXBVyQiAtl8AoGg VF9VV6xvro4UVZNJuAl3II47rTBbOVVpbRgxI572MbY2kQ5CtKR1ugzYuUyYvZ5DFXbY VXMQ== X-Forwarded-Encrypted: i=1; AJvYcCVsDi3xGmj7bmzFhmR9sCldJCyRL/uFTCu5t5nx6sFcxL+RACOJRMvbwb7yg7hFxiOU1uanyHlQkkL5RSiL7REMdW6p X-Gm-Message-State: AOJu0YxOul/k9cQpk4LrspEif5QdhG0CMtHkrujaWD6Zq2xQmbJ5Zx1r qsg0oDk8ROGPi/YdsCxpLEWSnyCBR/yl9f+e9nTdjwP0fJZBW6pbT0CcFg== X-Google-Smtp-Source: AGHT+IFiy1vN526uS/0Rp5UxKiaahsNyt/QtzGQ0LI3H2hfbzx7CAKBo4lertOw3DVOkGzeRd7GOuA== X-Received: by 2002:a05:6000:1e8b:b0:362:2518:fb59 with SMTP id ffacd0b85a97d-36319d685c8mr333571f8f.70.1718739183665; Tue, 18 Jun 2024 12:33:03 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36c2f.dip0.t-ipconnect.de. [217.227.108.47]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3624aac87f8sm1819013f8f.12.2024.06.18.12.33.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 12:33:03 -0700 (PDT) In-Reply-To: <87tthq830y.fsf@gmail.com> (Helmut Eller's message of "Tue, 18 Jun 2024 21:27:41 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=gerd.moellmann@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320266 Archived-At: Helmut Eller writes: > On Tue, Jun 18 2024, Eli Zaretskii wrote: > >>> Could this be our old friend dump_discard_mem that is too lazy to check >>> error codes? What happens if you remove the call to >>> dump_mmap_discard_contents in pdumper_load? >> >> Then the build succeeds. > > With the patch below, dump_mmap_discard_contents calls the map->release > callback. I think that was the original reason for having this > callback. It also adds stricter error checking to dump_discard_mem, but > that function is now unused. It's not clear to me, when it should be > used instead of dump_unmap_file. Pushed.