unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [patch] Use in `file-truename' in `flymake-create-temp-inplace'
@ 2012-07-20  9:39 Arne Jørgensen
  0 siblings, 0 replies; only message in thread
From: Arne Jørgensen @ 2012-07-20  9:39 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

If the temp-name in `flymake-create-temp-inplace' is going through
symlinks reported errors might not get catched if they contain the
expanded file name.

Wrapping temp-name in `file-truename' will make the file names
consistent in the error reports and in flymake.

Kind regards,
Arne


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: flymake.patch --]
[-- Type: text/x-patch, Size: 818 bytes --]

--- flymake.el-OLD	2012-07-20 11:36:07.000000000 +0200
+++ flymake.el	2012-07-20 11:36:16.000000000 +0200
@@ -1529,10 +1529,10 @@
     (error "Invalid file-name"))
   (or prefix
       (setq prefix "flymake"))
-  (let* ((temp-name   (concat (file-name-sans-extension file-name)
-			      "_" prefix
-			      (and (file-name-extension file-name)
-				   (concat "." (file-name-extension file-name))))))
+  (let* ((temp-name (file-truename (concat (file-name-sans-extension file-name)
+                                           "_" prefix
+                                           (and (file-name-extension file-name)
+                                                (concat "." (file-name-extension file-name)))))))
     (flymake-log 3 "create-temp-inplace: file=%s temp=%s" file-name temp-name)
     temp-name))
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-07-20  9:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-20  9:39 [patch] Use in `file-truename' in `flymake-create-temp-inplace' Arne Jørgensen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).