From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?iso-8859-1?Q?Arne_J=F8rgensen?= Newsgroups: gmane.emacs.devel Subject: [patch] Use in `file-truename' in `flymake-create-temp-inplace' Date: Fri, 20 Jul 2012 11:39:40 +0200 Organization: Arne Joergensen -- http://arnested.dk/ Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1342777202 25527 80.91.229.3 (20 Jul 2012 09:40:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 20 Jul 2012 09:40:02 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 20 11:40:02 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ss9gn-00057R-81 for ged-emacs-devel@m.gmane.org; Fri, 20 Jul 2012 11:40:01 +0200 Original-Received: from localhost ([::1]:41155 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ss9gm-0002Jk-KC for ged-emacs-devel@m.gmane.org; Fri, 20 Jul 2012 05:40:00 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ss9gf-0002JT-1W for emacs-devel@gnu.org; Fri, 20 Jul 2012 05:39:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ss9ge-0005eo-Ag for emacs-devel@gnu.org; Fri, 20 Jul 2012 05:39:52 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:36838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ss9ge-0005eS-3V for emacs-devel@gnu.org; Fri, 20 Jul 2012 05:39:52 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Ss9gb-0004r1-P4 for emacs-devel@gnu.org; Fri, 20 Jul 2012 11:39:49 +0200 Original-Received: from 109.202.128.38 ([109.202.128.38]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Jul 2012 11:39:49 +0200 Original-Received: from arne by 109.202.128.38 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Jul 2012 11:39:49 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 37 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 109.202.128.38 User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1 (darwin) Cancel-Lock: sha1:ndclgRlm9QEaSOP53bjfVpO+Ni8= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151775 Archived-At: --=-=-= Content-Type: text/plain If the temp-name in `flymake-create-temp-inplace' is going through symlinks reported errors might not get catched if they contain the expanded file name. Wrapping temp-name in `file-truename' will make the file names consistent in the error reports and in flymake. Kind regards, Arne --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=flymake.patch --- flymake.el-OLD 2012-07-20 11:36:07.000000000 +0200 +++ flymake.el 2012-07-20 11:36:16.000000000 +0200 @@ -1529,10 +1529,10 @@ (error "Invalid file-name")) (or prefix (setq prefix "flymake")) - (let* ((temp-name (concat (file-name-sans-extension file-name) - "_" prefix - (and (file-name-extension file-name) - (concat "." (file-name-extension file-name)))))) + (let* ((temp-name (file-truename (concat (file-name-sans-extension file-name) + "_" prefix + (and (file-name-extension file-name) + (concat "." (file-name-extension file-name))))))) (flymake-log 3 "create-temp-inplace: file=%s temp=%s" file-name temp-name) temp-name)) --=-=-=--