unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: John Wiegley <jwiegley@gmail.com>
To: raman <raman@google.com>
Cc: emacs-devel@gnu.org
Subject: Re: Suggest: dont declare interactive-p obsolete
Date: Wed, 18 Nov 2015 20:16:21 -0800	[thread overview]
Message-ID: <m24mgi7hey.fsf@newartisans.com> (raw)
In-Reply-To: <p91a8qasqci.fsf@google.com> (raman@google.com's message of "Wed,  18 Nov 2015 17:57:49 -0800")

>>>>> raman  <raman@google.com> writes:

> This is a minor change -- that will let existing code run without warnings.
> If we turned the defun in subr.el to a defsubst and dropped the (declare
> (obsolete called-interactively-p "23.2")) (called-interactively-p
> 'interactive))

I don't see any downsides to this; others?

John



  reply	other threads:[~2015-11-19  4:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19  1:57 Suggest: dont declare interactive-p obsolete raman
2015-11-19  4:16 ` John Wiegley [this message]
2015-11-19  8:39   ` Artur Malabarba
2015-11-19 13:06     ` Andreas Röhler
2015-11-19 13:46       ` Dmitry Gutov
2015-11-20  7:29         ` Andreas Röhler
2015-11-19 13:44     ` Dmitry Gutov
2015-11-19 15:29   ` Eli Zaretskii
2015-11-19 16:25     ` John Wiegley
2015-11-19 17:32       ` raman
2015-11-19 17:47         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m24mgi7hey.fsf@newartisans.com \
    --to=jwiegley@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=raman@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).