unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: master 57d2f24: * lisp/frame.el (make-frame-on-monitor): New command. (Bug#34516)
Date: Thu, 28 Feb 2019 10:38:49 +0100	[thread overview]
Message-ID: <m24l8o45hy.fsf@gmail.com> (raw)
In-Reply-To: 877edluew8.fsf@mail.linkov.net

Juri Linkov <juri@linkov.net> writes:

>>> Iʼve lost track: did we still want to fake monitor names on recent
>>> versions of macOS where the existing name retrieval methods donʼt work
>>> anymore?
>
> Yes, please add fake monitor names to support this command on macOS too.
>

I can do that. I have a small problem with 'make-frame-on-monitor':
the resulting frame is too tall (itʼs correctly
positioned though). Perhaps toolbars etc need to be
accounted for?

(display-monitor-attributes-list) =>
(((name . "DISPLAY1") (geometry 0 0
1440 900) (workarea 0 23 1440 877) (mm-size 285 179) (frames #<frame
*scratch* 0x7faffa066230>) (source . "NS")))

The frame resulting from 'make-frame-on-monitor' has (frame-geometry) =>
((outer-position 0 . 23) (outer-size 1475 . 868)
(external-border-size 0 . 0) (title-bar-size 0 . 22)
(menu-bar-external) (menu-bar-size 0 . 0) (tool-bar-external . t)
(tool-bar-position . top) (tool-bar-size 1471 . 35)
(internal-border-width . 2))

If I maximize that frame so itʼs the correct height, (frame-geometry)
=>

((outer-position 0 . 23) (outer-size 1475 . 842) (external-border-size 0 . 0) (title-bar-size 0 . 22) (menu-bar-external) (menu-bar-size 0 . 0) (tool-bar-external . t) (tool-bar-position . top) (tool-bar-size 1471 . 35) (internal-border-width . 2))

(Iʼll note that both outer-size and tool-bar-size are wider than the
actual display, so perhaps this is an issue in the macOS code geometry
code).

Robert



  reply	other threads:[~2019-02-28  9:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190225211142.21954.14993@vcs0.savannah.gnu.org>
     [not found] ` <20190225211144.0DD23206A2@vcs0.savannah.gnu.org>
2019-02-26  9:12   ` master 57d2f24: * lisp/frame.el (make-frame-on-monitor): New command. (Bug#34516) Robert Pluim
2019-02-26 15:23     ` Eli Zaretskii
2019-02-27 20:59       ` Juri Linkov
2019-02-28  9:38         ` Robert Pluim [this message]
2019-02-28 16:52           ` Robert Pluim
2019-02-28 20:40             ` Juri Linkov
2019-03-01 13:40               ` Robert Pluim
2019-03-02 21:09                 ` Juri Linkov
2019-03-03  1:05                   ` Drew Adams
2019-03-03 21:30                     ` Juri Linkov
2019-03-04  0:01                       ` Drew Adams
2019-03-04  8:53                   ` Robert Pluim
2019-02-28 18:11         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m24l8o45hy.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).