From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Keith David Bershatsky Newsgroups: gmane.emacs.devel Subject: Re: buffer.c/buffer.h: How to add new buffer-local variables? Date: Mon, 08 Apr 2019 17:40:33 -0700 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="224853"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org, schwab@linux-m68k.org, monnier@iro.umontreal.ca, acm@muc.de, eliz@gnu.org, dancol@dancol.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 09 02:41:26 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDepJ-000wOx-N8 for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 02:41:26 +0200 Original-Received: from localhost ([127.0.0.1]:32951 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDepI-00070q-KF for ged-emacs-devel@m.gmane.org; Mon, 08 Apr 2019 20:41:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDeog-00070h-2z for emacs-devel@gnu.org; Mon, 08 Apr 2019 20:40:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDeoe-0007HC-Fr for emacs-devel@gnu.org; Mon, 08 Apr 2019 20:40:46 -0400 Original-Received: from gateway24.websitewelcome.com ([192.185.51.253]:24990) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDeoZ-0007Db-2w for emacs-devel@gnu.org; Mon, 08 Apr 2019 20:40:41 -0400 Original-Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway24.websitewelcome.com (Postfix) with ESMTP id DA4CE130870 for ; Mon, 8 Apr 2019 19:40:34 -0500 (CDT) Original-Received: from gator3053.hostgator.com ([50.87.144.69]) by cmsmtp with SMTP id DeoUhH6u1YTGMDeoUhQ81Z; Mon, 08 Apr 2019 19:40:34 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lawlist.com ; s=default; h=Content-Type:MIME-Version:Subject:Cc:To:From:Message-ID:Date: Sender:Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vfZ/gWk1fQk9OfJ0MTXLV51dsf4704NbVfkqDZ8Gh/M=; b=lLAC1xjHQS/19Sv203FLuA43u4 n4hvYiWw1ZzxHF6QfPjqCC4QkBiViS2GVmIp9tALunfJn161hE26PUbYIuRivykE6V+dqhfn517N6 JfcYlCkXmUGo+oKIDdp0wVs2xlIr52m9Hy9Ubv9R0etPqoK01E+165SvUI+Sy1uIqJLMxkPWKQRZa Y9rBqgm84dFPn471P46vnewnoZPrdqy+7mh9Lu+WN0ZjGthafB5jsSVyIDaYGOHMWKQZoPvaonFfU uqWkgMNZ3L3KxC4gkSR0/kZhugboZ8OLWvSs9y/2U/GK4b7TKtqt/hHsDkE0t0TIvJs1ZUM8f0GcQ IwXM1GVQ==; Original-Received: from cpe-45-48-239-195.socal.res.rr.com ([45.48.239.195]:52721 helo=server.local) by gator3053.hostgator.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.91) (envelope-from ) id 1hDeoT-002laX-Og; Mon, 08 Apr 2019 19:40:33 -0500 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator3053.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lawlist.com X-BWhitelist: no X-Source-IP: 45.48.239.195 X-Source-L: No X-Exim-ID: 1hDeoT-002laX-Og X-Source-Sender: cpe-45-48-239-195.socal.res.rr.com (server.local) [45.48.239.195]:52721 X-Source-Auth: lawlist X-Email-Count: 6 X-Source-Cap: bGF3bGlzdDtsYXdsaXN0O2dhdG9yMzA1My5ob3N0Z2F0b3IuY29t X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 192.185.51.253 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235142 Archived-At: Is it possible that a038df77de7b1aa2d73a6478493b8838b59e4982 broke the ability for Emacs to maintain the value of certain WINDOW Lisp_Object defined in window.h? Here is a snippet from a modified window.h. All of the WINDOW caches for the fake cursors are coming back as INVALID_LISP_OBJECT. A test for NILP on those invalid lisp objects comes back TRUE, and subsequent functions fail when trying to process the object that reports as being "DEAD" in gdb printouts. This happens on the NS and w32 ports of Emacs. I have not tested X11, but I assume the result will be the same. If it is highly unlikely that a038df77de7b1aa2d73a6478493b8838b59e4982 is the culprit, then I would imagine that the culprit is somewhere between March 28, 2019 and today. If anyone would like me to start going back in time to test other comments between March 28, 2019 and today, please let me know .... /* An alist with parameters. */ Lisp_Object window_parameters; /* The help echo text for this window. Qnil if there's none. */ Lisp_Object mode_line_help_echo; /* *************************************************************************** */ /* MULTIPLE-CURSORS */ Lisp_Object mc_temp_cache; /* The cache for multiple fake cursors. */ Lisp_Object mc_cache; /* The cache for crosshairs. */ Lisp_Object ch_cache; /* The cache for visible fill column. */ Lisp_Object fc_cache; /* L.S.L. color vector used by crosshairs. */ Lisp_Object ch_foreground; /* L.S.L. color vector used by visible fill column. */ Lisp_Object fc_foreground; /* *************************************************************************** */ /* No Lisp data may follow this point; mode_line_help_echo must be the last Lisp member. */ /* Glyph matrices. */ struct glyph_matrix *current_matrix; struct glyph_matrix *desired_matrix;