From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrii Kolomoiets Newsgroups: gmane.emacs.devel Subject: Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188) Date: Thu, 24 Sep 2020 23:21:33 +0300 Message-ID: References: <20200904211737.15548.63989@vcs0.savannah.gnu.org> <20200904211738.DA94720667@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35825"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 24 22:22:33 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLXlA-0009CL-QX for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Sep 2020 22:22:32 +0200 Original-Received: from localhost ([::1]:51216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLXl9-0003I8-Rv for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Sep 2020 16:22:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLXkJ-0002q8-Ew for emacs-devel@gnu.org; Thu, 24 Sep 2020 16:21:39 -0400 Original-Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:35443) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLXkI-00057A-0k for emacs-devel@gnu.org; Thu, 24 Sep 2020 16:21:39 -0400 Original-Received: by mail-lf1-x136.google.com with SMTP id w11so305240lfn.2 for ; Thu, 24 Sep 2020 13:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=N+ER1FoCCQRZmgQ1uRqNq7XtLlN2wUxNEySdRf+PRLc=; b=asbqrkzp/CZfG9F5nrR1GQGThTWKzGdXJWmIgOvLzRF0gDgkUNcbC6RRkOi5l/Dpbb PkoITZa2nJYuAiThoTHLCsavtwy1MCp03ypvLWj6JtSrABnOCoBLPDtYMOSH+dwoE8Aa MbeGlq9BipXVy9dr4PhONxyITZsb5720gGH1wGsY+IsN09wigG965DmAFswg/nWJUja7 jEK2FdIu8nMnXal7rJ/f2nSJGVLfGTNeMteE+06rJooMox8wOoipvAQJ/hZaPmcrNtpD RX8lJJjiXzxpRSflK+nXCEbZ2proJveu8njPDnHjM7pu5QFe1HzwRyy72FMF7usUaS5T MMcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=N+ER1FoCCQRZmgQ1uRqNq7XtLlN2wUxNEySdRf+PRLc=; b=pjhkr7XUGOS2UYTQgzjXDWf4P8PJYsLPROCffNJfGEL6E4aoqWtnT8TSU7Uf99ahWR qyo4lJKJe2P3C/j3Gm7wjVtmIkjj9CA+UAKBFr7Tv6VdD3GEV4UJW40imZ03B9BZFCli SPJsbCZX8Tqh7dwLhE974SQTpPxAkls+fbEDbvnoyN5SbS18EI0J4aCbBZKnOwobcYIV fiV8M34ZxPvSSDJKFORXZvEgQx/23u8fTPtQhWJ1Hn0VwHUuX36EJFtRtepf1FgU/kvf 02CYUc6h14l2Oqj5JpKgM0/nWF320It1Svmf2wDTt3DDWMXph5VtJJjRjnE79BuBYXgq VYWA== X-Gm-Message-State: AOAM531w9FlpFyUtmPWH++dtJpxw8FF6dijxpmsCyf3/vtZKR1Ufwl6F PfVj0qhiR2EN5iOPwkYBCtonhw+CHfw= X-Google-Smtp-Source: ABdhPJzvBIaFjkUO3T7ELwZ/Lu91Pq+g0WLxzdVadWVnDrz4crPgnBah62br4L5LFHSiU5RKth+yQA== X-Received: by 2002:a19:5611:: with SMTP id k17mr181832lfb.528.1600978895586; Thu, 24 Sep 2020 13:21:35 -0700 (PDT) Original-Received: from muffinmac ([91.206.110.141]) by smtp.gmail.com with ESMTPSA id h11sm285731lfd.21.2020.09.24.13.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 13:21:34 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Fri, 18 Sep 2020 11:53:51 -0400") Received-SPF: pass client-ip=2a00:1450:4864:20::136; envelope-from=andreyk.mad@gmail.com; helo=mail-lf1-x136.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256403 Archived-At: Stefan Monnier writes: > Done, There are still the case when point position is not saved on ewoc-invalidate - when the buffer is displayed in the other window: 1. mkdir gittest && cd gittest && git init && touch foo 2. emacs -Q 3. C-x v d 4. n 5. o 6. o 7. C-x C-s Point is moved to BOL. Because 8. M-: (save-current-buffer (set-buffer "*vc-dir*") (goto-char 1)) will not move point in the *vc-dir*. Is it worth it to restore the point position in each window where it will be affected by 'ewoc--refresh-node'?