From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Andrea Corallo <acorallo@gnu.org>
Cc: emacs-devel@gnu.org, "Gerd Möllmann" <gerd@gnu.org>
Subject: Re: master f92520d009e 1/2: Don't pause display for pending input
Date: Thu, 19 Dec 2024 12:17:19 +0100 [thread overview]
Message-ID: <m24j2z9b28.fsf@gmail.com> (raw)
In-Reply-To: <yp1a5cs9c80.fsf@fencepost.gnu.org> (Andrea Corallo's message of "Thu, 19 Dec 2024 05:52:15 -0500")
Andrea Corallo <acorallo@gnu.org> writes:
> Gerd Moellmann <gerd@gnu.org> writes:
>
>> branch: master
>> commit f92520d009e1ab8024b03d9d71ecc9820573c040
>> Author: Gerd Möllmann <gerd@gnu.org>
>> Commit: Gerd Möllmann <gerd@gnu.org>
>>
>> Don't pause display for pending input
>>
>> * src/dispnew.c: Remove display_completed, redisplay_dont_pause,
>> redisplay-dont-pause was declared obsolete in Emacs 24. Remove anything
>> checking pending input, change function signatures accordingly, and so
>> on.
>>
>> * src/keyboard.c (read_char): Don't use redisplay_dont_pause.
>> * src/minibuf.c (read_minibuf): Use new function signatures.
>> * src/xdisp.c: Don't check display_completed. Use new API.
>>
>> * lisp/subr.el (redisplay-dont-pause): Remove declaration.
>
> I think instances of 'Qredisplay_dont_pause' are still present in the
> codebase so some build configurations are now broken (at least my
> GNU/Linux one).
>
> =====
> xterm.c:6372:13: error: ‘Qredisplay_dont_pause’ undeclared (first use in this function)
> 6372 | specbind (Qredisplay_dont_pause, Qt);
> | ^~~~~~~~~~~~~~~~~~~~~
> xterm.c:6372:13: note: each undeclared identifier is reported only once for each function it appears in
> xfns.c: In function ‘Fx_print_frames_dialog’:
> xfns.c:9967:13: error: ‘Qredisplay_dont_pause’ undeclared (first use in this function)
> 9967 | specbind (Qredisplay_dont_pause, Qt);
> | ^~~~~~~~~~~~~~~~~~~~~
> xfns.c:9967:13: note: each undeclared identifier is reported only once for each function it appears in
> =====
>
> Could you have a look?
>
> Thanks
Thanks, should be fixed now.
next prev parent reply other threads:[~2024-12-19 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <173460276132.331083.7195719813421951970@vcs3.savannah.gnu.org>
[not found] ` <20241219100603.94BA7C031EB@vcs3.savannah.gnu.org>
2024-12-19 10:52 ` master f92520d009e 1/2: Don't pause display for pending input Andrea Corallo
2024-12-19 11:17 ` Gerd Möllmann [this message]
2024-12-19 12:04 ` Andrea Corallo
2024-12-19 12:24 ` Gerd Möllmann
2024-12-19 12:44 ` Eli Zaretskii
2024-12-19 13:06 ` Gerd Möllmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24j2z9b28.fsf@gmail.com \
--to=gerd.moellmann@gmail.com \
--cc=acorallo@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gerd@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).