From: Andreas Schwab <schwab@linux-m68k.org>
To: Daniel Colascione <dancol@dancol.org>
Cc: Ken Brown <kbrown@cornell.edu>, Emacs <emacs-devel@gnu.org>
Subject: Re: Is the Cygw32 port ready for testing?
Date: Mon, 15 Oct 2012 09:34:38 +0200 [thread overview]
Message-ID: <m2391grxwx.fsf@igel.home> (raw)
In-Reply-To: <507B68BD.2050409@dancol.org> (Daniel Colascione's message of "Sun, 14 Oct 2012 18:37:01 -0700")
Daniel Colascione <dancol@dancol.org> writes:
> === modified file 'src/dbusbind.c'
> --- src/dbusbind.c 2012-09-15 07:06:56 +0000
> +++ src/dbusbind.c 2012-10-15 01:30:49 +0000
> @@ -32,6 +32,10 @@
> #define DBUS_NUM_MESSAGE_TYPES 5
> #endif
>
> +#ifdef interface
> +#undef interface
> +#endif
There is no need for #ifdef, and of course it should be amended by a
comment.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2012-10-15 7:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 22:44 Is the Cygw32 port ready for testing? Ken Brown
2012-10-14 23:28 ` Daniel Colascione
2012-10-15 1:16 ` Ken Brown
2012-10-15 1:31 ` Ken Brown
2012-10-15 1:34 ` Daniel Colascione
2012-10-15 1:37 ` Daniel Colascione
2012-10-15 7:34 ` Andreas Schwab [this message]
2012-10-15 14:14 ` Ken Brown
2012-10-15 17:16 ` Eli Zaretskii
2012-10-15 19:33 ` Ken Brown
2012-10-15 19:35 ` Daniel Colascione
2012-10-15 21:31 ` Daniel Colascione
2012-10-15 21:34 ` Ken Brown
2012-10-15 21:36 ` Daniel Colascione
2012-10-16 13:23 ` Ken Brown
2012-10-16 18:24 ` Eli Zaretskii
2012-10-17 4:13 ` Stephen J. Turnbull
2012-10-17 15:42 ` Eli Zaretskii
2012-10-17 17:36 ` Stephen J. Turnbull
2012-10-17 23:45 ` Nix
2012-10-18 12:28 ` Ken Brown
2012-10-18 17:02 ` Daniel Colascione
2012-10-18 22:18 ` Ken Brown
2012-10-18 17:09 ` Eli Zaretskii
2012-10-18 22:04 ` Stefan Monnier
2012-10-19 6:43 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2012-10-19 16:03 Angelo Graziosi
2012-10-20 2:42 ` Ken Brown
2012-10-20 2:49 ` Daniel Colascione
2012-10-20 6:53 ` Andreas Schwab
2012-10-21 13:02 ` Stephen J. Turnbull
2012-10-20 8:53 ` Angelo Graziosi
2012-10-20 10:29 ` Eli Zaretskii
2012-10-20 13:19 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2391grxwx.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).