From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "John Wiegley" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add new function to test whether a key is present in a hash table. Date: Thu, 15 Feb 2018 22:51:58 -0800 Message-ID: References: <20180215203406.64372-1-phst@google.com>> <2ce9b5db-b17d-415c-8dc6-6046a31269be@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1518763874 21071 195.159.176.226 (16 Feb 2018 06:51:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 16 Feb 2018 06:51:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (darwin) Cc: Philipp Stephani , Philipp Stephani , emacs-devel@gnu.org To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 16 07:51:10 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emZrH-0004U6-00 for ged-emacs-devel@m.gmane.org; Fri, 16 Feb 2018 07:50:59 +0100 Original-Received: from localhost ([::1]:45017 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emZtJ-0000Xt-4l for ged-emacs-devel@m.gmane.org; Fri, 16 Feb 2018 01:53:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emZtB-0000XW-Vb for emacs-devel@gnu.org; Fri, 16 Feb 2018 01:52:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emZtB-0002Av-5Z for emacs-devel@gnu.org; Fri, 16 Feb 2018 01:52:58 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emZt7-00029k-0j; Fri, 16 Feb 2018 01:52:53 -0500 Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:56639) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1emZt6-0006Xy-PZ; Fri, 16 Feb 2018 01:52:52 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id DBDB420A78; Fri, 16 Feb 2018 01:52:51 -0500 (EST) Original-Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Fri, 16 Feb 2018 01:52:51 -0500 X-ME-Sender: Original-Received: from localhost (76-234-69-149.lightspeed.frokca.sbcglobal.net [76.234.69.149]) by mail.messagingengine.com (Postfix) with ESMTPA id 6B38B7E34D; Fri, 16 Feb 2018 01:52:51 -0500 (EST) In-Reply-To: <2ce9b5db-b17d-415c-8dc6-6046a31269be@default> (Drew Adams's message of "Thu, 15 Feb 2018 14:08:42 -0800 (PST)") Mail-Followup-To: Drew Adams , Philipp Stephani , emacs-devel@gnu.org, Philipp Stephani X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222803 Archived-At: >>>>> "DA" == Drew Adams writes: DA> 2. The function name should have `key' in it, I think. Suggestion: DA> `hash-table-contains-key-p' or even just `hash-table-key-p'. It seems a bit strange that the name isn't something like "hashash", since knowing "puthash" and "gethash" would never help you guess hash-table-contains-key-p. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2