From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: emacs-27 60c84ad: ; * etc/TODO: Fix last change. Date: Fri, 06 Mar 2020 17:32:40 +0100 Message-ID: References: <20200229173124.11831.98476@vcs0.savannah.gnu.org> <83d09txw29.fsf@gnu.org> <83lfogw1gn.fsf@gnu.org> <83eeu8vy0e.fsf@gnu.org> <83v9njutez.fsf@gnu.org> <83tv33uop0.fsf@gnu.org> <83o8tbunzh.fsf@gnu.org> <83lfoevod9.fsf@gnu.org> <83k13yvn8u.fsf@gnu.org> <83blpavd0l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="104308"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, YAMAMOTO Mitsuharu , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 06 17:33:40 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jAFut-000R26-T2 for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Mar 2020 17:33:39 +0100 Original-Received: from localhost ([::1]:38870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAFus-0006FD-V3 for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Mar 2020 11:33:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50282) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAFu2-0005Zq-C0 for emacs-devel@gnu.org; Fri, 06 Mar 2020 11:32:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jAFu0-0004zz-W9 for emacs-devel@gnu.org; Fri, 06 Mar 2020 11:32:46 -0500 Original-Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:37157) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jAFu0-0004wb-LH; Fri, 06 Mar 2020 11:32:44 -0500 Original-Received: by mail-wr1-x435.google.com with SMTP id 6so3108738wre.4; Fri, 06 Mar 2020 08:32:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=coH8UXjsK20kOkIint7YfXlTlg0LvamGNRX7jDdj860=; b=OUXPlihaN7NFe7QAOLMcDhH7P8Xd4A/290/PU3HAl9LkPAzeW4v4tXMGRSB+KEUNtK O5+XRLwf1THND5f6fRI9tfMdbOLt4tZbrCXcvR7sSar74wU9nrWoQthVvtwDz1o6DASe baZpyPqfEKZ4nh81N9tyLukvz6n0Dr7KC2eUukZwGmmhtGmOnHzC/htzYU8m5lY6Gjim Z6tmRiHHPU+5r2urXTMWMnynGJGmN1cMvtIaWQ4NljPyjVUYiqMmOJHvAGBmx/xR77Kw qROLwMV5Jx4I75YjoDw71shU9gPBR0Q8xpU8NwbEE5j5/6Loj6RBoZicNX7UPpO0Q/rd Hq3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=coH8UXjsK20kOkIint7YfXlTlg0LvamGNRX7jDdj860=; b=eCAUTbyVkaN/LSMtuQs/6GMtmLENhua/M22D/qbh0FRUtYVGdRJL9ESuRza9RKVeRw 5EGnzQnUhO2G05e7+kLVjzihskK3LgMwA55yKNHrhSyoyAcAz95VSXUU3KZlsuKeyy+v fHx3GfdhM0QjaDkUxYL89wdKdzVQxyVt8jEx/O3ZOiJeC7pAVOxXulFM6AE8Tl69zi4p /AGqSpMZnKZ+0xBlF3hbOT1QD3OtBuM3Bet3/L0JYptsfQiLovaoPq18xIkrQdJ1LoxN wSqPUzEKsti9Bcm4+WtUOslIIHiwUV3c5Q01e8hfjdvXR6CQ+Or3JuVhZR2RGGb06+4V jqOw== X-Gm-Message-State: ANhLgQ1wY+9DLwhu1UFNlihR0smJZiNQY+tCcUiyUx0jfoM6QgUrPicC P0bloHsNsJDfzs8DOyzk3YeKM2mr X-Google-Smtp-Source: ADFU+vtle7E1fHPmYvXQ6a7WIF0kOPoMkYIDzGmTIY2N3UQsPKzNnxPXo9oW4OjWUjw3zEbL3YmSkg== X-Received: by 2002:adf:eb51:: with SMTP id u17mr5113493wrn.29.1583512362463; Fri, 06 Mar 2020 08:32:42 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id h10sm15649001wml.18.2020.03.06.08.32.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2020 08:32:41 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: <83blpavd0l.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Mar 2020 21:04:58 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::435 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245288 Archived-At: >>>>> On Thu, 05 Mar 2020 21:04:58 +0200, Eli Zaretskii said: >> If you look at the list of Emoji codepoints I sent earlier, I think >> you'll agree that they're all over the place. But at least this makes >> the patch smaller :-) Eli> Yes. And I think the Emoji that are outside of those 4 blocks are= of Eli> the kind that by default display in their text presentation, isn't Eli> that right? A lot of them, yes, but not all. E.g. U+231A has Emoji =3D=3D yes, and Emoji_Presentation =3D=3D yes. >> Note that with this, and Symbola disabled, this does not display a >> glyph for U+1F300 on macOS unless I prepend 'Apple Color Emoji' to t= he >> frame's fontset. Is that expected on macOS? Eli> I'm not familiar with how Emacs on macOS looks for fonts, sorry. = On Eli> Windows, we will need the help of w32-find-non-USB-fonts to find t= he Eli> built-in fonts for Emoji (because there are no Unicode sub-range b= its Eli> for Emoji), if Noto Color Emoji is not installed, so maybe somethi= ng Eli> similar is needed on macOS. Maybe Yamamoto-san (CC'ed) can chime = in Eli> and help us here. So this was a combination of me forgetting to add 'emoji' into the list of 'simple' scripts in fontset.el, and the following code in macfont.m: /* Don't use a color bitmap font unless its family is explicitly specified. */ if ((sym_traits & kCTFontTraitColorGlyphs) && NILP (family)) continue; Yamamoto-san, I=CA=BCm not sure I understand the rationale for excluding colour fonts unless explicitly requested, could you elaborate? >> - else if (name ~ /punctuation|mathematical|arrows|currency|super= script|small form variants|geometric|dingbats|enclosed|alchemical|pictograp= h|emoticon|transport/) return "symbol" >> + else if (name ~ /transport|supplemental symbols/) return "emoji" >> + else if (name ~ /punctuation|mathematical|arrows|currency|super= script|small form variants|geometric|dingbats|enclosed|alchemical|pictograp= h/) return "symbol" Eli> I think we should also convert "variation selectors" to "emoji". = We Eli> must have the same font selected for variation selectors and for t= he Eli> emoticons, otherwise character composition will not work. Done for FE00-FE0F. >> + (emoji #x1F300))) Eli> I think we should add at least #x1F600 and #xFE0F as representative Eli> characters for 'emoji'. OK. >> + (set-fontset-font "fontset-default" 'emoji >> + "Noto Color Emoji" nil 'prepend) Eli> I think it's better to use '("Noto Color Emoji" . "iso10646-1") Eli> instead of just the family name, for consistency if nothing else. Right. For some reason I thought it didn=CA=BCt work with iso10646-1, but my testing must have been flawed. Robert