From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-27 d66331a: Don't build the Gnulib 'utimens' module on MinGW
Date: Tue, 24 Mar 2020 21:31:47 +0100 [thread overview]
Message-ID: <m2369xh4uk.fsf@gmail.com> (raw)
In-Reply-To: <83wo79a8f7.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 24 Mar 2020 20:56:28 +0200")
>>>>> On Tue, 24 Mar 2020 20:56:28 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: emacs-devel@gnu.org
>> Date: Tue, 24 Mar 2020 18:07:13 +0100
>>
>> In that case I should go the other direction. How about the following
>> to remove the 1-char readahead for sockets (which then allows us to
>> enable datagram sockets on MSWindows).
Eli> I have no idea whether and how the result will differ from what we do
Eli> today. The sheer amount of "remarks" in the MSDN documentation scares
Eli> me. E.g., what happens if the remote end closes the socket,
Eli> gracefully or otherwise?
We still end up calling read on the socket, just later, so those
error conditions should still be handled. Iʼll note that the gnulib
implementation of select does essentially the same thing (it uses
MsgWaitForMultipleObjects rather than WaitForSingleObject, but I
assume they do much the same thing under the covers).
Eli> IOW, I'd love someone who _really_ knows about Windows socket
Eli> programming to review this and compare with what we do now. I'm not
Eli> that person, sorry.
Nor am I. Iʼd suggest adding it as a disabled option, but then nobody
would ever use it....
Robert
prev parent reply other threads:[~2020-03-24 20:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200323143828.31224.77075@vcs0.savannah.gnu.org>
[not found] ` <20200323143829.ED56720E43@vcs0.savannah.gnu.org>
2020-03-23 15:26 ` emacs-27 d66331a: Don't build the Gnulib 'utimens' module on MinGW Robert Pluim
2020-03-23 15:52 ` Eli Zaretskii
2020-03-24 17:07 ` Robert Pluim
2020-03-24 18:56 ` Eli Zaretskii
2020-03-24 20:31 ` Robert Pluim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2369xh4uk.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).