From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Helmut Eller <eller.helmut@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: MPS native subrs
Date: Tue, 25 Jun 2024 22:10:37 +0200 [thread overview]
Message-ID: <m234p0zsua.fsf@pro2.fritz.box> (raw)
In-Reply-To: <87ikxwamor.fsf_-_@gmail.com> (Helmut Eller's message of "Tue, 25 Jun 2024 20:42:44 +0200")
Helmut Eller <eller.helmut@gmail.com> writes:
> On Sat, Jun 22 2024, Helmut Eller wrote:
>>>> I thought native comp works for you?
>>
>> I haven't tried with the latest dump loading code. I think that needs
>> some work for native-comp-units.
>
> Here are some patches for this.
Thanks. Looks like gnu.org is down, for some time now. I'll push your
patches when it works again.
> I also have some questions:
Oh oh :-)
> 1) In fix_subr, the &s->intspec.native field should only traced if the
> subr is a non-primitive. Because, for primitives, it's a (possibly
> non-aligned) char*. Right?
Right. I thought I had copied that literally from process_mark_stack,
but apparently not. In process_mark_stack it reads
if (NATIVE_COMP_FUNCTIONP (obj))
{
set_vector_marked (ptr);
struct Lisp_Subr *subr = XSUBR (obj);
mark_stack_push_value (subr->intspec.native);
mark_stack_push_value (subr->command_modes);
mark_stack_push_value (subr->native_comp_u);
mark_stack_push_value (subr->lambda_list);
mark_stack_push_value (subr->type);
}
And command_modes is even fixed twice in fix_subr. There went
something seriously wrong :-/.
> 2) In dump_subr, the command_modes field is dumped with dump_field_lv
> for non-primitives but for primitives with dump_field_emacs_ptr.
> Is this intentional or a bug?
Hm, strange. I also can't make sense of that. For meLisp_Object is
Lisp_Object and not a pointer.
>
> 3) In fix_subr, why is the command_modes field only traced if
> HAVE_NATIVE_COMP? (Today was the first time I heard of the
> command-modes function; still have no clue what it's used for :-)
Ja, see 1). Looks like a blackout to me. No idea. Maybe that's from the
phase after I had first tried to mix the two GCs, so that I could make
incremental progress, object type by object, Then I gave up on that
because it didn't work well, and finally had to get "everything" done
with a big bang. That was so incredibly mechanical work that possibly my
brain wandered off intermittendly :-/.
How command-modes, a defun, is exactly used I don't know either, sorry.
I understand the doc string as indicating that certain commands are only
applicable in certain modes, in the sense of minor- and major-mode. I
don't remember that from the good old days, and it doesn't seem to be
explained anywhere.
next prev parent reply other threads:[~2024-06-25 20:10 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 19:25 MPS: profiler Ihor Radchenko
2024-06-20 19:40 ` Eli Zaretskii
2024-06-20 19:48 ` Ihor Radchenko
2024-06-20 19:58 ` Gerd Möllmann
2024-06-20 20:29 ` Ihor Radchenko
2024-06-21 5:57 ` Gerd Möllmann
2024-06-21 6:17 ` Eli Zaretskii
2024-06-21 6:54 ` Gerd Möllmann
2024-06-21 7:16 ` Eli Zaretskii
2024-06-21 7:32 ` Gerd Möllmann
2024-06-21 7:19 ` Helmut Eller
2024-06-21 7:36 ` Ihor Radchenko
2024-06-21 7:44 ` Helmut Eller
2024-06-21 7:51 ` Gerd Möllmann
2024-06-21 8:21 ` Helmut Eller
2024-06-21 8:31 ` Gerd Möllmann
2024-06-21 10:45 ` Eli Zaretskii
2024-06-21 11:47 ` Gerd Möllmann
2024-06-21 12:01 ` Helmut Eller
2024-06-21 12:09 ` Ihor Radchenko
2024-06-21 12:42 ` Helmut Eller
2024-06-21 12:51 ` Ihor Radchenko
2024-06-21 14:49 ` MPS make-thread (was: MPS: profiler) Helmut Eller
2024-06-21 15:20 ` MPS make-thread Gerd Möllmann
2024-06-21 15:33 ` Gerd Möllmann
2024-06-21 15:42 ` Helmut Eller
2024-06-21 16:46 ` Gerd Möllmann
2024-06-21 18:31 ` Gerd Möllmann
2024-06-21 19:58 ` Ihor Radchenko
2024-06-21 20:10 ` Gerd Möllmann
2024-06-22 18:52 ` Ihor Radchenko
2024-06-22 19:17 ` Eli Zaretskii
2024-06-23 3:18 ` Gerd Möllmann
2024-06-23 4:54 ` Gerd Möllmann
2024-06-23 6:19 ` Eli Zaretskii
2024-06-23 5:53 ` Eli Zaretskii
2024-06-23 6:45 ` Gerd Möllmann
2024-06-23 8:53 ` Eli Zaretskii
2024-06-23 9:36 ` Gerd Möllmann
2024-06-23 10:21 ` Gerd Möllmann
2024-06-23 10:27 ` Gerd Möllmann
2024-06-23 13:19 ` Eli Zaretskii
2024-06-23 14:16 ` Gerd Möllmann
2024-06-26 11:20 ` Ihor Radchenko
2024-06-26 11:25 ` Gerd Möllmann
2024-06-22 19:26 ` Gerd Möllmann
2024-06-22 6:29 ` Eli Zaretskii
2024-06-22 18:53 ` Ihor Radchenko
2024-06-22 19:04 ` Eli Zaretskii
2024-06-22 19:17 ` Ihor Radchenko
2024-06-22 18:13 ` Helmut Eller
2024-06-22 18:31 ` Gerd Möllmann
2024-06-25 18:42 ` MPS native subrs (was: MPS make-thread) Helmut Eller via Emacs development discussions.
2024-06-25 20:10 ` Gerd Möllmann [this message]
2024-06-25 20:48 ` MPS native subrs Gerd Möllmann
2024-06-26 6:31 ` Helmut Eller
2024-06-26 7:00 ` Gerd Möllmann
2024-06-26 13:45 ` Eli Zaretskii
2024-06-26 14:18 ` Gerd Möllmann
2024-06-26 15:15 ` Helmut Eller
2024-06-26 17:12 ` Gerd Möllmann
2024-06-26 13:30 ` Eli Zaretskii
2024-06-26 13:34 ` Eli Zaretskii
2024-06-26 4:55 ` Gerd Möllmann
2024-06-26 13:36 ` Eli Zaretskii
2024-06-26 13:26 ` MPS native subrs (was: MPS make-thread) Eli Zaretskii
2024-06-26 14:41 ` MPS native subrs Andrea Corallo
2024-06-21 12:43 ` MPS: profiler Gerd Möllmann
2024-06-21 16:11 ` Ihor Radchenko
2024-06-21 12:41 ` Gerd Möllmann
2024-06-21 14:10 ` Eli Zaretskii
2024-06-21 16:09 ` Ihor Radchenko
2024-06-21 16:22 ` Gerd Möllmann
2024-06-21 18:51 ` Ihor Radchenko
2024-06-21 18:58 ` Gerd Möllmann
2024-06-21 19:23 ` Ihor Radchenko
2024-06-21 19:50 ` Gerd Möllmann
2024-06-21 20:02 ` Ihor Radchenko
2024-06-22 6:37 ` Eli Zaretskii
2024-06-21 7:43 ` Gerd Möllmann
2024-06-21 7:50 ` Ihor Radchenko
2024-06-21 7:53 ` Gerd Möllmann
2024-06-21 10:39 ` Eli Zaretskii
2024-06-21 10:57 ` Ihor Radchenko
2024-06-21 10:58 ` Eli Zaretskii
2024-06-21 11:20 ` Ihor Radchenko
2024-06-21 11:29 ` Eli Zaretskii
2024-06-21 11:33 ` Gerd Möllmann
2024-06-21 19:55 ` Dmitry Gutov
2024-06-21 16:12 ` Ihor Radchenko
2024-06-21 18:48 ` Eli Zaretskii
2024-06-21 10:49 ` Pip Cet
2024-06-21 10:56 ` Eli Zaretskii
2024-06-21 5:56 ` Eli Zaretskii
2024-06-21 6:14 ` Ihor Radchenko
2024-06-20 19:50 ` Gerd Möllmann
2024-06-20 20:02 ` Ihor Radchenko
2024-06-21 5:58 ` Eli Zaretskii
2024-06-21 6:16 ` Ihor Radchenko
2024-06-21 8:23 ` Pip Cet
2024-06-21 8:43 ` Ihor Radchenko
2024-06-21 8:50 ` Gerd Möllmann
2024-06-21 10:43 ` Eli Zaretskii
2024-06-21 11:00 ` Pip Cet
2024-06-21 11:09 ` Eli Zaretskii
2024-06-21 11:39 ` Gerd Möllmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m234p0zsua.fsf@pro2.fritz.box \
--to=gerd.moellmann@gmail.com \
--cc=eliz@gnu.org \
--cc=eller.helmut@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).