From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: weak hash tables Date: Sun, 07 Jul 2024 09:31:17 +0200 Message-ID: References: <878qyeffjh.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23398"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Ihor Radchenko , Helmut Eller , Eli Zaretskii , emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 07 09:32:03 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQMNP-0005u9-9S for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Jul 2024 09:32:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQMMq-0007ck-Mg; Sun, 07 Jul 2024 03:31:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQMMl-0007c6-Is for emacs-devel@gnu.org; Sun, 07 Jul 2024 03:31:26 -0400 Original-Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQMMj-0004sF-Qo; Sun, 07 Jul 2024 03:31:23 -0400 Original-Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a77dc08db60so169915466b.1; Sun, 07 Jul 2024 00:31:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720337479; x=1720942279; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GY6guEXAz1hp8QFGIgTYnokjmDoJ8m/pPmK9AI8EPN0=; b=mMYyqudQOzIaCNlbxpY4j7V0c6aIZAsi4TxEnZ92SP6JsCV/lT9Y2DAX9sKaX5tRUs 3PABQ4zSv51Ugclp2/yt5EjVitfr7qyIBE3aQnnfYJ1jmGqOmAnH9rF0aI3CxgoW9lyS ceS3//+utom7msf88zzl4Li0iGchIP2SV6Mq27h1wMd4f0q8DJBVt5mY/0N+/ZUVOL5M UTKJ4EZp+qcoOa7+ev6CwSXr4a+VMZ8OD0sJr057uT2p0aA9SRV53H5Vv0X+ubxo2ugh Ete4YYfgBV2VrWys6msfl+MMy01RRc+e6x461KUx3U+KcEcafkxCD4ByE2YyPfF3wptD 113Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720337479; x=1720942279; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GY6guEXAz1hp8QFGIgTYnokjmDoJ8m/pPmK9AI8EPN0=; b=AnMLpBWGx9rUFGzw0uz+TuYzEzsoDoOhU1GWTbe+8FjcjR/gQQCt69OmM4t/kPMaEZ ChXDPHRXch0+OHePex6QBWm6kmJIziW+XdrN+9GfRpYLHWoMVA0ehJ2isCD3B42MNigi +cOGMlKt347jHnSTMpGpnK0qhSPEYU4od2jdgAo6hP9mejhin6m8R17myWf/9hqzLz6N FIMev7lBLW28Xt2XtUHTl93I9VPOW68HBQVg6J6C64KDMaevvLaXqBQs1kaonpV4JEb1 7kJVrzA6lIpJysDf33vq8MTxqlU6mYaUEhJqiThXGnsPWDBn1VzoHTpnTMHAl6y8sgzq EzFw== X-Forwarded-Encrypted: i=1; AJvYcCU8cSqrSeZJvN+oUg4r0q/nONQ90esKPJJ2q4m4rj/hT3UfgGOdheUhDNWZEY1hOpc2ERvBBDVkno6Dqg/Sga1PxbK53BVE0OjtRpY4Vq26o80= X-Gm-Message-State: AOJu0YxM6Ts/iBw0U6jv9LUc+AN6cIxN8Kz6MPQnNWvqXUiLslNcgBkn M6Y1fA7FFs3OS76uwUeNsKNoII1Oia+dw5icOZgjw2WZ8t3piuJtsmhxOA== X-Google-Smtp-Source: AGHT+IH4Z8R2QNjyR8t4MMuNzau0liNG05B5UYe9LyOOpBHdRypGSJwBjvmfLYzytIWjMBN/hMJ/6g== X-Received: by 2002:a17:906:f2c8:b0:a6f:4804:d41a with SMTP id a640c23a62f3a-a77ba70c750mr585809766b.55.1720337478660; Sun, 07 Jul 2024 00:31:18 -0700 (PDT) Original-Received: from pro2.fritz.box (p4fe3a778.dip0.t-ipconnect.de. [79.227.167.120]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77e3f43f7fsm114204366b.5.2024.07.07.00.31.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jul 2024 00:31:18 -0700 (PDT) In-Reply-To: (Pip Cet's message of "Sun, 07 Jul 2024 06:38:42 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321470 Archived-At: Pip Cet writes: > On Sunday, July 7th, 2024 at 04:27, Gerd M=C3=B6llmann wrote: >> Ihor Radchenko yantar92@posteo.net writes: >> > Gerd M=C3=B6llmann gerd.moellmann@gmail.com writes: >> >=20 >> > > So, we had 14 * 64M total before, and 16 * 64M afterwards. A bit more >> > > makes sense since we now have GMP objects, but a dramatic improvemen= t? >> > > ... >> > >=20 >> > > That's the only thing I can come up with ATM. Complete guesswork, of >> > > course. I wonder how one would find an "optimal" configuration at al= l. >> >=20 >> > I feel kind of silly, but >> > https://memory-pool-system.readthedocs.io/en/latest/guide/perf.html >> > maybe? It has an example of "dramatic improvement". >>=20 >> Interestingly, the 3 gens have the opposite effect with the Helmut showe= d. >>=20 >> master passed 27/54 ert-test-run-tests-batch-expensive (5.857224 sec) >> 2-gen passed 27/54 ert-test-run-tests-batch-expensive (80.113908 sec) >> 3-gen passed 27/54 ert-test-run-tests-batch-expensive (142.356406 sec) > > I'm confused by that test. I see similar results to you when I "make lisp= /emacs-lisp/ert-tests", but when I run the test directly it finishes quickl= y: > > $ ../src/emacs -Q --batch -f igc--collect -l lisp/emacs-lisp/ert-tests.el= --eval '(ert-run-tests-batch-and-exit "ert-test-run-tests-batch-expensive"= )' > > Running 1 tests (2024-07-07 06:00:57-0000, selector =E2=80=98"ert-test-ru= n-tests-batch-expensive"=E2=80=99) > passed 1/1 ert-test-run-tests-batch-expensive (1.079868 sec) > > Ran 1 tests, 1 results as expected, 0 unexpected (2024-07-07 06:00:58-000= 0, 1.080000 sec) > > > What's going on here? > > Pip I see the same % ../src/emacs -Q --batch -f igc--collect -l lisp/emacs-lisp/ert-tests.el= --eval '(ert-run-tests-batch-and-exit "ert-test-run-tests-batch-expensive"= )' Running 1 tests (2024-07-07 09:29:07+0200, selector =E2=80=98"ert-test-ru= n-tests-batch-expensive"=E2=80=99) passed 1/1 ert-test-run-tests-batch-expensive (2.679200 sec) Ran 1 tests, 1 results as expected, 0 unexpected (2024-07-07 09:29:10+020= 0, 2.679337 sec) 3-gen case, 140s down to 2.5. Wot?