Re: [peter@runestig.com: Re: emacs-cvs built on Windows XP crashes on Windows 2000]

Re: [peter@runestig.com: Re: emacs-cvs built on Windows XP crashes on Windows 2000]

[jasonr]

I think it is right, but there should be another place
in the code where these variables are currently
being initialized (presumably at dump time).
That initialization should be removed to prevent
future confusion.

>  from:    Richard Stallman <rms@gnu.org>
>  date:    Thu, 05 Sep 2002 03:47:35
>  to:      emacs-devel@gnu.org
>  subject: Re: [peter@runestig.com: Re: emacs-cvs built on Windows XP crashes on Windows 2000]
> 
> Can someone who uses Windows see if this is right, and install it if so?
> 
> ------- Start of forwarded message -------
> Envelope-to: rms@gnu.org
> Delivery-date: Wed, 04 Sep 2002 09:07:14 -0400
> To: bug-gnu-emacs@gnu.org
> Subject: Re: emacs-cvs built on Windows XP crashes on Windows 2000
> From: "Peter 'Luna' Runestig" <peter@runestig.com>
> In-Reply-To: <001301c25405$cc50eb20$64110b0a@datavis.se>
> Sender: bug-gnu-emacs-admin@gnu.org
> Date: 04 Sep 2002 15:05:43  0200
> 
> This is a quick hack to make it roll again:
> 
> diff -urN emacs-cvs.orig/src/emacs.c emacs-cvs/src/emacs.c
> - --- emacs-cvs.orig/src/emacs.c	Wed Aug 28 08:28:30 2002
>     emacs-cvs/src/emacs.c	Wed Sep  4 14:38:07 2002
> @@ -1536,6  1536,19 @@
>        keys_of_window ();
>      }
>  
>  #ifdef HAVE_NTGUI
>    {
>      /* these must be initialized every run time */
>      extern FARPROC track_mouse_event_fn;
>      extern FARPROC get_menu_item_info;
>      extern FARPROC set_menu_item_info;
>      HMODULE user32 = GetModuleHandle ("user32.dll");
>      track_mouse_event_fn = GetProcAddress (user32, "TrackMouseEvent");
>      get_menu_item_info = GetProcAddress (user32, "GetMenuItemInfoA");
>      set_menu_item_info = GetProcAddress (user32, "SetMenuItemInfoA");
>    }
>  #endif /* HAVE_NTGUI */
>  
>    if (!noninteractive)
>      {
>  #ifdef VMS
> 
> Cheers,
> - - Peter
> - -- 
> Peter 'Luna' Runestig (fd. Altberg), Sweden <peter@runestig.com>
> PGP Key ID: 0xD07BBE13
> Fingerprint: 7B5C 1F48 2997 C061 DE4B  42EA CB99 A35C D07B BE13
> AOL Instant Messenger Screenname: PRunestig
> 
> 
> 
> 
> _______________________________________________
> Bug-gnu-emacs mailing list
> Bug-gnu-emacs@gnu.org
> http://mail.gnu.org/mailman/listinfo/bug-gnu-emacs
> ------- End of forwarded message -------
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://mail.gnu.org/mailman/listinfo/emacs-devel

Re: [peter@runestig.com: Re: emacs-cvs built on Windows XP crashes on Windows 2000]

[Richard Stallman]

Thanks for looking at it.  Would someone else please install the change?

I don't entirely understand the rest of your comments:

    I think it is right, but there should be another place
    in the code where these variables are currently
    being initialized (presumably at dump time).

Do you mean you believe there is one, or you think the code
should be changed to have one?

    That initialization

Which of the two do you mean?

			should be removed to prevent
    future confusion.

Re: [peter@runestig.com: Re: emacs-cvs built on Windows XP crashes on Windows 2000]

[Jason Rumney]

Richard Stallman <rms@gnu.org> writes:

> Thanks for looking at it.  Would someone else please install the change?
> 
> I don't entirely understand the rest of your comments:
> 
>     I think it is right, but there should be another place
>     in the code where these variables are currently
>     being initialized (presumably at dump time).
> 
> Do you mean you believe there is one, or you think the code
> should be changed to have one?

I believe there is one already, and it should be removed after this
change to avoid duplication (and thus confusion over which is
actually important).

>     That initialization
> 
> Which of the two do you mean?

The one that was there already.

Re: [peter@runestig.com: Re: emacs-cvs built on Windows XP crashes on Windows 2000]

[Richard Stallman]

    I believe there is one already, and it should be removed after this
    change to avoid duplication (and thus confusion over which is
    actually important).

Can you find that code and send a patch for someone to install?

[peter@runestig.com: Re: emacs-cvs built on Windows XP crashes on Windows 2000]

[Richard Stallman]

Can someone who uses Windows see if this is right, and install it if so?

------- Start of forwarded message -------
Envelope-to: rms@gnu.org
Delivery-date: Wed, 04 Sep 2002 09:07:14 -0400
To: bug-gnu-emacs@gnu.org
Subject: Re: emacs-cvs built on Windows XP crashes on Windows 2000
From: "Peter 'Luna' Runestig" <peter@runestig.com>
In-Reply-To: <001301c25405$cc50eb20$64110b0a@datavis.se>
Sender: bug-gnu-emacs-admin@gnu.org
Date: 04 Sep 2002 15:05:43 +0200

This is a quick hack to make it roll again:

diff -urN emacs-cvs.orig/src/emacs.c emacs-cvs/src/emacs.c
- --- emacs-cvs.orig/src/emacs.c	Wed Aug 28 08:28:30 2002
+++ emacs-cvs/src/emacs.c	Wed Sep  4 14:38:07 2002
@@ -1536,6 +1536,19 @@
       keys_of_window ();
     }
 
+#ifdef HAVE_NTGUI
+  {
+    /* these must be initialized every run time */
+    extern FARPROC track_mouse_event_fn;
+    extern FARPROC get_menu_item_info;
+    extern FARPROC set_menu_item_info;
+    HMODULE user32 = GetModuleHandle ("user32.dll");
+    track_mouse_event_fn = GetProcAddress (user32, "TrackMouseEvent");
+    get_menu_item_info = GetProcAddress (user32, "GetMenuItemInfoA");
+    set_menu_item_info = GetProcAddress (user32, "SetMenuItemInfoA");
+  }
+#endif /* HAVE_NTGUI */
+
   if (!noninteractive)
     {
 #ifdef VMS

Cheers,
- - Peter
- -- 
Peter 'Luna' Runestig (fd. Altberg), Sweden <peter@runestig.com>
PGP Key ID: 0xD07BBE13
Fingerprint: 7B5C 1F48 2997 C061 DE4B  42EA CB99 A35C D07B BE13
AOL Instant Messenger Screenname: PRunestig




_______________________________________________
Bug-gnu-emacs mailing list
Bug-gnu-emacs@gnu.org
http://mail.gnu.org/mailman/listinfo/bug-gnu-emacs
------- End of forwarded message -------