From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: Status of MAC/W32/X consolidation -- first major patch committed. Date: 16 Mar 2003 22:27:58 +0000 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <5xadg38lnj.fsf@kfs2.cua.dk> <5xheaaq93k.fsf@kfs2.cua.dk> <5xbs0bq8en.fsf_-_@kfs2.cua.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1047853703 2525 80.91.224.249 (16 Mar 2003 22:28:23 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 16 Mar 2003 22:28:23 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sun Mar 16 23:28:20 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18ugc8-0000eY-00 for ; Sun, 16 Mar 2003 23:28:20 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18uh1V-0003NO-00 for ; Sun, 16 Mar 2003 23:54:33 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18ugcf-0006Wj-04 for emacs-devel@quimby.gnus.org; Sun, 16 Mar 2003 17:28:53 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18ugcG-0006JQ-00 for emacs-devel@gnu.org; Sun, 16 Mar 2003 17:28:28 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18ugcC-00065x-00 for emacs-devel@gnu.org; Sun, 16 Mar 2003 17:28:25 -0500 Original-Received: from server0011.freedom2surf.net ([194.106.56.14] helo=server0027.freedom2surf.net) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18ugc9-0005yX-00 for emacs-devel@gnu.org; Sun, 16 Mar 2003 17:28:21 -0500 Original-Received: from nyaumo.jasonr.f2s.com ([195.137.103.251]) h2GMSMRT008074; Sun, 16 Mar 2003 22:28:23 GMT Original-Received: from nyaumo.jasonr.f2s.com (localhost [127.0.0.1]) by nyaumo.jasonr.f2s.com (Postfix) with ESMTP id E4D354A941; Sun, 16 Mar 2003 22:27:58 +0000 (GMT) Original-To: no-spam@cua.dk (Kim F. Storm) In-Reply-To: <5xbs0bq8en.fsf_-_@kfs2.cua.dk> Original-Lines: 23 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12391 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12391 As part of your changes, you introduced the following function: static void w32_get_glyph_overhangs (glyph, f, left, right) struct glyph *glyph; struct frame *f; int *left, *right; { HDC hdc = get_frame_dc (f); /* Convert to unicode! */ x_get_glyph_overhangs (glyph, f, left, right); release_frame_dc (f, hdc); } What does the comment "Convert to unicode!" mean? Is there work required to properly convert this to Windows? If that is the case, I don't know when I would get time to look at it, and it will probably get forgotten. It would be better to revert that part of the change. As it is, the function is not needed. Since hdc is never used, there is no point retrieving and releasing it. So we might as well use x_get_glyph_overhangs directly.