From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.devel Subject: Re: simple patch for `align.el' Date: Sat, 23 Oct 2004 17:17:06 -0700 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1098577117 2911 80.91.229.6 (24 Oct 2004 00:18:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 24 Oct 2004 00:18:37 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 24 02:18:23 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CLW5X-0002TF-00 for ; Sun, 24 Oct 2004 02:18:23 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CLWD6-0003GH-75 for ged-emacs-devel@m.gmane.org; Sat, 23 Oct 2004 20:26:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CLWCy-0003DN-Lq for emacs-devel@gnu.org; Sat, 23 Oct 2004 20:26:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CLWCx-0003Cw-V1 for emacs-devel@gnu.org; Sat, 23 Oct 2004 20:26:04 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CLWCx-0003Cm-RS for emacs-devel@gnu.org; Sat, 23 Oct 2004 20:26:03 -0400 Original-Received: from [66.111.4.26] (helo=out2.smtp.messagingengine.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CLW5E-00069A-Cw for emacs-devel@gnu.org; Sat, 23 Oct 2004 20:18:04 -0400 Original-Received: from frontend3.messagingengine.com (frontend3.internal [10.202.2.152]) by frontend1.messagingengine.com (Postfix) with ESMTP id 31D0AC33C63 for ; Sat, 23 Oct 2004 20:18:03 -0400 (EDT) X-Sasl-enc: YG+WwBJlraXR08DHS/2hTg 1098577082 Original-Received: from Majnun.local (ppp-67-114-59-179.dialup.irvnca.pacbell.net [67.114.59.179]) by frontend3.messagingengine.com (Postfix) with ESMTP id 4FDC125599 for ; Sat, 23 Oct 2004 20:18:02 -0400 (EDT) Original-Received: by Majnun.local (Postfix, from userid 501) id 3CDE86079BB; Sat, 23 Oct 2004 17:17:07 -0700 (PDT) Original-To: emacs-devel@gnu.org In-Reply-To: (Paul Pogonyshev's message of "Sun, 24 Oct 2004 01:38:03 +0300") User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (darwin) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:28813 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:28813 Paul Pogonyshev writes: > then select this region and `M-x align' it. The first line will > have a space followed by a tab, which is not good and is frowned > upon by the `whitespace' module. The simple patch below fixes this. The patch looks fine enough to me. Just take care that the deletion does not adversely affect any markers. I remember having lots of subtle bugs with that in the past. I'd advise testing this change across a reasonably large file, and then diff'ing to make sure that only the desired fix results. John