unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "John Wiegley" <johnw@newartisans.com>
To: emacs-devel@gnu.org
Subject: Recommend move eshell/su and eshell/sudo to em-tramp.el
Date: Thu, 28 Jun 2012 22:32:22 -0500	[thread overview]
Message-ID: <m21ukyaj3t.fsf@newartisans.com> (raw)

Something I've noticed after moving to Emacs 24 is that using "sudo" in Eshell
has become an awful experience:

    - It's *much* slower than *sudo (by orders of magnitude)
    - It doesn't show any output until the command is done
    - It locks up Emacs until the command is done

I find this behavior distasteful, since sudo is such a common command for
users of Eshell to use.  It was added in 2009 by the Tramp author:

    2009-11-27  Michael Albinus  <michael.albinus@gmx.ed>

           * eshell/em-unix.el (eshell/su, eshell/sudo): New defuns,
           providing a Tramp related implementation of "su" and "sudo".
           (eshell-unix-initialize): Add "su" and "sudo".

I appreciate what these two functions are trying to accomplish, but they
should not have been made the default.  I recommend moving them out of
em-unix.el and into a new module, em-tramp.el, which is OFF by default.  Users
who prefer to use Tramp for everything can turn it on, and a note to that
effect should be added to the Tramp manual.

John



             reply	other threads:[~2012-06-29  3:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29  3:32 John Wiegley [this message]
2012-06-29  9:45 ` Recommend move eshell/su and eshell/sudo to em-tramp.el Michael Albinus
2012-06-29 21:51 ` Phil Hagelberg
  -- strict thread matches above, loose matches on Subject: below --
2012-07-02 19:25 John Wiegley
2012-07-03  6:56 ` Michael Albinus
2012-07-03 19:47   ` John Wiegley
2012-07-04 14:53     ` Michael Albinus
2012-07-10 12:22   ` Michael Albinus
2012-07-10 16:57     ` John Wiegley
2012-07-10 18:56       ` Michael Albinus
2012-07-11  3:57         ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m21ukyaj3t.fsf@newartisans.com \
    --to=johnw@newartisans.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).