* Re: emacs-25 97abf92: * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.
[not found] ` <E1a8ZdA-0003rh-E8@vcs.savannah.gnu.org>
@ 2015-12-15 8:19 ` Glenn Morris
2015-12-15 15:23 ` John Wiegley
2015-12-15 16:09 ` Eli Zaretskii
0 siblings, 2 replies; 4+ messages in thread
From: Glenn Morris @ 2015-12-15 8:19 UTC (permalink / raw)
To: emacs-devel; +Cc: johnw
John Wiegley wrote:
> branch: emacs-25
> commit 97abf9273a80e0890b4756ec4d09d8bfe4077bba
> Author: foudfou <foudil.newbie+git@gmail.com>
> Commit: John Wiegley <johnw@newartisans.com>
>
> * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.
The convention is that the commit message should describe the changes to
individual functions, variables etc. Also "Copyright-paperwork-exempt: yes"
is missing in this case. Also I believe that real names are preferred
unless the author actively wants to use a pseudonym.
(Normally you run 'make change-history' and fix these things in the
generated ChangeLog, but that remains inoperable for non-master branches.)
Finally maybe it merits a NEWS entry, I dunno (did not look at the
actual substance of the patch).
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: emacs-25 97abf92: * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.
2015-12-15 8:19 ` emacs-25 97abf92: * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region Glenn Morris
@ 2015-12-15 15:23 ` John Wiegley
2015-12-15 16:09 ` Eli Zaretskii
1 sibling, 0 replies; 4+ messages in thread
From: John Wiegley @ 2015-12-15 15:23 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
>>>>> Glenn Morris <rgm@gnu.org> writes:
> The convention is that the commit message should describe the changes to
> individual functions, variables etc. Also "Copyright-paperwork-exempt: yes"
> is missing in this case. Also I believe that real names are preferred unless
> the author actively wants to use a pseudonym.
> (Normally you run 'make change-history' and fix these things in the
> generated ChangeLog, but that remains inoperable for non-master branches.)
> Finally maybe it merits a NEWS entry, I dunno (did not look at the actual
> substance of the patch).
Thanks, Glenn, I'll do the followup work on this.
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: emacs-25 97abf92: * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.
2015-12-15 8:19 ` emacs-25 97abf92: * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region Glenn Morris
2015-12-15 15:23 ` John Wiegley
@ 2015-12-15 16:09 ` Eli Zaretskii
2015-12-15 18:00 ` John Wiegley
1 sibling, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2015-12-15 16:09 UTC (permalink / raw)
To: Glenn Morris; +Cc: johnw, emacs-devel
> From: Glenn Morris <rgm@gnu.org>
> Date: Tue, 15 Dec 2015 03:19:44 -0500
> Cc: johnw@newartisans.com
>
> John Wiegley wrote:
>
> > branch: emacs-25
> > commit 97abf9273a80e0890b4756ec4d09d8bfe4077bba
> > Author: foudfou <foudil.newbie+git@gmail.com>
> > Commit: John Wiegley <johnw@newartisans.com>
> >
> > * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.
>
> The convention is that the commit message should describe the changes to
> individual functions, variables etc. Also "Copyright-paperwork-exempt: yes"
> is missing in this case. Also I believe that real names are preferred
> unless the author actively wants to use a pseudonym.
Right, all this (and more) is in CONTRIBUTE.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: emacs-25 97abf92: * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.
2015-12-15 16:09 ` Eli Zaretskii
@ 2015-12-15 18:00 ` John Wiegley
0 siblings, 0 replies; 4+ messages in thread
From: John Wiegley @ 2015-12-15 18:00 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Glenn Morris, emacs-devel
>>>>> Eli Zaretskii <eliz@gnu.org> writes:
>> The convention is that the commit message should describe the changes to
>> individual functions, variables etc. Also "Copyright-paperwork-exempt: yes"
>> is missing in this case. Also I believe that real names are preferred
>> unless the author actively wants to use a pseudonym.
> Right, all this (and more) is in CONTRIBUTE.
Right, I think I got caught up in making sure the copyright assignments were
all in order, then forgot to do due diligence on the form of the contribution
itself.
Hand = slapped. Puts CONTRIBUTE on tonight's reading list. :)
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-15 18:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151214202200.14819.23782@vcs.savannah.gnu.org>
[not found] ` <E1a8ZdA-0003rh-E8@vcs.savannah.gnu.org>
2015-12-15 8:19 ` emacs-25 97abf92: * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region Glenn Morris
2015-12-15 15:23 ` John Wiegley
2015-12-15 16:09 ` Eli Zaretskii
2015-12-15 18:00 ` John Wiegley
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).