unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* tiny pdumper fix
@ 2018-09-23 18:26 Charles A. Roelli
  2018-09-28 20:34 ` Stefan Monnier
  0 siblings, 1 reply; 3+ messages in thread
From: Charles A. Roelli @ 2018-09-23 18:26 UTC (permalink / raw)
  To: emacs-devel

I'd like to push this change to the pdumper branch to allow building
on older macOS (less than 10.11, I think), where only MAP_ANON is
defined:

--- a/src/pdumper.c
+++ b/src/pdumper.c
@@ -4101,6 +4101,11 @@ dump_anonymous_allocate_w32 (void *base,
 #endif
 }
 
+/* Old versions of macOS only define MAP_ANON, not MAP_ANONYMOUS.  */
+#ifndef MAP_ANONYMOUS
+#define MAP_ANONYMOUS MAP_ANON
+#endif
+
 static void *
 dump_anonymous_allocate_posix (void *base,
                                size_t size,

Is it well placed here, or does it belong in the header file instead?



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: tiny pdumper fix
  2018-09-23 18:26 tiny pdumper fix Charles A. Roelli
@ 2018-09-28 20:34 ` Stefan Monnier
  2018-09-29 11:30   ` Charles A. Roelli
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2018-09-28 20:34 UTC (permalink / raw)
  To: emacs-devel

> I'd like to push this change to the pdumper branch to allow building
> on older macOS (less than 10.11, I think), where only MAP_ANON is
> defined:

Hmm... looks like none of those people who know about pdumper or macOS
was available.  Sorry.
I just installed you patch as is.

> Is it well placed here, or does it belong in the header file instead?

It probably belongs elsewhere, but I pushed it as-is,


        Stefan




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: tiny pdumper fix
  2018-09-28 20:34 ` Stefan Monnier
@ 2018-09-29 11:30   ` Charles A. Roelli
  0 siblings, 0 replies; 3+ messages in thread
From: Charles A. Roelli @ 2018-09-29 11:30 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Fri, 28 Sep 2018 16:34:03 -0400
> 
> > I'd like to push this change to the pdumper branch to allow building
> > on older macOS (less than 10.11, I think), where only MAP_ANON is
> > defined:
> 
> Hmm... looks like none of those people who know about pdumper or macOS
> was available.  Sorry.
> I just installed you patch as is.
> 
> > Is it well placed here, or does it belong in the header file instead?
> 
> It probably belongs elsewhere, but I pushed it as-is,

ACK, thanks.  From the autoconf documentation, it looks like
AC_CHECK_DECL may be useful here.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-29 11:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-23 18:26 tiny pdumper fix Charles A. Roelli
2018-09-28 20:34 ` Stefan Monnier
2018-09-29 11:30   ` Charles A. Roelli

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).