unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: timo.myyra@bittivirhe.fi (Timo Myyrä)
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: add pthread_set_name_np support
Date: Mon, 29 Jun 2020 10:26:59 +0200	[thread overview]
Message-ID: <m21rlyuvjg.fsf@gmail.com> (raw)
In-Reply-To: <87v9jcpt7d.fsf@asteroid.bittivirhe.fi> ("Timo Myyrä"'s message of "Sat, 27 Jun 2020 15:51:50 +0300")

>>>>> On Sat, 27 Jun 2020 15:51:50 +0300, timo.myyra@bittivirhe.fi (Timo Myyrä) said:

    Timo> diff --git a/configure.ac b/configure.ac
    Timo> index b1b8c846e1..f198894e02 100644
    Timo> --- a/configure.ac
    Timo> +++ b/configure.ac
    Timo> @@ -4187,7 +4187,8 @@ AC_DEFUN
    Timo>  sendto recvfrom getsockname getifaddrs freeifaddrs \
    Timo>  gai_strerror sync \
    Timo>  getpwent endpwent getgrent endgrent \
    Timo> -cfmakeraw cfsetspeed __executable_start log2 pthread_setname_np)
    Timo> +cfmakeraw cfsetspeed __executable_start log2 pthread_setname_np \
    Timo> +pthread_set_name_np)
    Timo>  LIBS=$OLD_LIBS
 
    Timo>  if test "$ac_cv_func_pthread_setname_np" = "yes"; then
    Timo> @@ -4222,6 +4223,23 @@ AC_DEFUN
    Timo>    fi
    Timo>  fi

Iʼm confused; why do you need the explicit check for
pthread_set_name_np when the AC_CHECK_FUNCS call above already checks
for it (and sets HAVE_PTHREAD_SET_NAME_NP if successful).

    Timo> +if test "$ac_cv_func_pthread_set_name_np" = "yes"; then
    Timo> +  AC_CACHE_CHECK(
    Timo> +   [whether pthread_set_name_np is supported],
    Timo> +   [emacs_cv_pthread_set_name_np],
    Timo> +   [AC_COMPILE_IFELSE(
    Timo> +     [AC_LANG_PROGRAM(
    Timo> +       [[#include <pthread.h>][#include <pthread_np.h>]],
    Timo> +       [[pthread_setname_np (1, "a");]])],
    Timo> +     [emacs_cv_pthread_set_name_np=yes],
    Timo> +     [emacs_cv_pthread_set_name_np=no])])
    Timo> +  if test "$emacs_cv_pthread_set_name_np" = "yes"; then
    Timo> +    AC_DEFINE(
    Timo> +      HAVE_PTHREAD_SET_NAME_NP, 1,
    Timo> +      [Define to 1 if pthread_set_name_np is supported.])
    Timo> +  fi
    Timo> +fi
    Timo> +



  parent reply	other threads:[~2020-06-29  8:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-27 10:49 add pthread_set_name_np support Timo Myyrä
2020-06-27 11:10 ` Eli Zaretskii
2020-06-27 12:51   ` Timo Myyrä
     [not found]     ` <C3EA421C-D39D-4FA3-A5EE-417E50E746AC@acm.org>
     [not found]       ` <87pn9kpenx.fsf@asteroid.bittivirhe.fi>
     [not found]         ` <4992EBB9-BEA9-4629-BCA5-462A252C86DC@acm.org>
     [not found]           ` <87lfk8p88e.fsf@asteroid.bittivirhe.fi>
     [not found]             ` <0C52F7EC-B5D1-493A-97C2-0A94AC9550BC@acm.org>
     [not found]               ` <87sgefdbhj.fsf@asteroid.bittivirhe.fi>
2020-06-28  9:38                 ` Mattias Engdegård
2020-06-29  8:26     ` Robert Pluim [this message]
2020-06-27 13:42   ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m21rlyuvjg.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=timo.myyra@bittivirhe.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).