From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: profiler Date: Fri, 21 Jun 2024 13:47:12 +0200 Message-ID: References: <87v823xvq1.fsf@localhost> <86cyobmmhc.fsf@gnu.org> <87r0crxung.fsf@localhost> <87le2zxsqx.fsf@localhost> <8634p6n7jd.fsf@gnu.org> <87tthm3gq2.fsf@gmail.com> <87sex6ags5.fsf@localhost> <87msne3flr.fsf@gmail.com> <87frt63dvt.fsf@gmail.com> <86o77ulgk8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14148"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: eller.helmut@gmail.com, yantar92@posteo.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 21 13:48:46 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKcl2-0003Pp-7i for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Jun 2024 13:48:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKcjv-00071K-DI; Fri, 21 Jun 2024 07:47:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKcjd-0006fe-GS for emacs-devel@gnu.org; Fri, 21 Jun 2024 07:47:21 -0400 Original-Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKcjb-0000L1-OM; Fri, 21 Jun 2024 07:47:16 -0400 Original-Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a6f1f33486eso99729366b.3; Fri, 21 Jun 2024 04:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718970433; x=1719575233; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8FDBxHAGl3DXh45u2pHWsPABQ+LanF8iYcqZDTnGpkg=; b=LCb6OnEwyXp7/0qCSq8dU1kXC/hNmSAfWq2pJmkKNjRl6EPJDSIO3FShEco0KwAj5E FX5iTXocxyhBisMzPIJYi9t1NX/5b7qFPzX2lnMVQglgbmQtLwdayacxUDWBDDTesUiR f2JVAwDL3hV3GMqzEOiMSQLLEvVQboMEF/EQX5iR/d0Cu0xyh3x5vZKwqUg/KHcHrzS6 DH458rTitafs/QtdDcIAkzmf2sxxCwDAFg4kYds7zwhUaHJrxJfS7hvuvy9zpqLC4pD6 EKrfYaDkVerVNiDxZk+hhw54UcOvz3fjHwRUKSFIW8M0EC+QlX4o2TrwLCAjiYjc7BdY syAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718970433; x=1719575233; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8FDBxHAGl3DXh45u2pHWsPABQ+LanF8iYcqZDTnGpkg=; b=co5zK4U+eb+zyC9VwZgYbBCE1NX02wu8hGF+gfeOZSVba3aZVPpatFR9PRsoJBdeKG 7+Gbcz2zMy8JmPzw7AV97fzp4pk2CSpLpCW7UQ/z4E1pT8ZgSl2XKP1Cmtupb6Zx7a7i dlQSmFga5ala+u0SL0cH6cM1VHC6yF48/c71ddcJ91F2E0S5EXcbTEC8xKhEvTw1gDX5 c56VpLk3JQByqDrq4LhAYG0CQCVTW7TXZ9gDFSjaaClrSMJmSSQGZCMJghfzGPN6h/uJ hU/YEEYiAJ+5HUHq+pMyX5+uVV4uDKtW6AWky1CZCYYR+PQs22OVx8edQlqKe4DfmQNu RX5A== X-Forwarded-Encrypted: i=1; AJvYcCW5XDmyVX4gS1BsHkeA4k47IVM3eh1HbSpaBLcTFXOxX5WzlnEepQYZESYhXFeZ2E4k8iupVNsUFtN+ju9gPjeJy/iP X-Gm-Message-State: AOJu0YxJHwDH6zGp3p1aMBjcwKkscsJ7OLP+uKk5OD15Zzge1GBwnFyq vFLrM+8WRWud/qAk614VJyY4Wk4+lANcoQGaMqxP9izlC0pPQWwoGJKlcA== X-Google-Smtp-Source: AGHT+IF9or8ZGaDrOeKdF8KXkgBu2bkcf7iO8XYRMX6qLfWdLVOH2ywiCF8TQgelM2kF63ihFuHTiA== X-Received: by 2002:a50:9b15:0:b0:57d:496:209a with SMTP id 4fb4d7f45d1cf-57d07e0d225mr6245825a12.6.1718970433272; Fri, 21 Jun 2024 04:47:13 -0700 (PDT) Original-Received: from pro2.fritz.box (p4fe3a72a.dip0.t-ipconnect.de. [79.227.167.42]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57d30f3002dsm757603a12.71.2024.06.21.04.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 04:47:12 -0700 (PDT) In-Reply-To: <86o77ulgk8.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 21 Jun 2024 13:45:59 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320395 Archived-At: Eli Zaretskii writes: >> >> Yes, the SIBPROF handler could at least return early then. >> > >> > Perhaps something like this? >> >> Not sure. The result of is_busy is only valid at the point in time when >> it is called. > > Are you thinking about what happens when GC is run concurrently? > Because this is not what happens here, AFAIU. Let's focus on fixing > the actual issue we see in the backtrace, and consider its possible > generalizations later. > > Are you saying that is_busy could return false in the situation we see > in the backtrace, i.e. during the entire time MPS processes its > protection-induced SIGSEGV? I'm still not sure. What I'm trying to say is that we need to be sure that there are no windows left in which things can change. I'd be most comfortable ATM if the first thing the SIGPROF handler does is check is_busy and immediately returns, doing nothing.