From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Filippo Argiolas Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] new package: eglot-inactive-regions Date: Thu, 05 Dec 2024 22:19:56 +0100 Message-ID: References: <874j3nrri7.fsf@posteo.net> <878qswlfty.fsf@posteo.net> <87ldwvjdzl.fsf@posteo.net> <878qsu3zln.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36581"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Gerd =?utf-8?Q?M=C3=B6llmann?= , Stefan Kangas , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 05 22:21:16 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJJHf-0009Jt-WA for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Dec 2024 22:21:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJJGi-0006VV-5H; Thu, 05 Dec 2024 16:20:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJJGg-0006Qx-51 for emacs-devel@gnu.org; Thu, 05 Dec 2024 16:20:14 -0500 Original-Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJJGe-0004Wr-DO for emacs-devel@gnu.org; Thu, 05 Dec 2024 16:20:13 -0500 Original-Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-434a2f3bae4so14741955e9.3 for ; Thu, 05 Dec 2024 13:20:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733433599; x=1734038399; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=PZ7Eg5ILAsfIj7Hx4YjyBM8UwtCQbnU1ij3s2PnEeYA=; b=D8SuuCFSEsjhNqNa2kEcNRuVSggrVd31hnIc7FJj5EpViG9MNTpKr54lqlVduL0cFH kF9VyotYnCa79JVhj8vyVI7b85Rl2U2MAZRsjGciKwPNgEsMmIEw2bVzfL5c22s83UF8 A1gduHm1PY9iwrwwdS0Fht2QxG/zfHfVoZQyXBBb/g7aLCRoRMPuVSqyx9NCi/Pe22Z9 zzkWHjHmqlxd3DirCo75pX48cNHmmidRXeRY7ZDXujAShw0bzbVBNKXJy2gg8Y9XjyLU EbynHD1A6xZei6GzMB6g1+ZD5ahLdNF/Lo4iD4wdcBjryCLv7H4Gai6Hw52pxPM1Y5HF cRaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733433599; x=1734038399; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PZ7Eg5ILAsfIj7Hx4YjyBM8UwtCQbnU1ij3s2PnEeYA=; b=up9LX+MxCrvtebopmdoT9Vn3X5wnlytCVyTdXphvEE251hZXoqpRvpzNowiYTyV5I7 vNDPthMer75v3bj02T3Ms4rdhwiKvt0Bfzg/aQgB+NCdrkZw7XRLpH32rTfyvAuOucRi 7c3mfzjN30bwhiWKtuBi+KF86JOPQozZ72sTp3Kt6YAhirmH20eeMoXbBt56mpSVNU3B DgldFFW3TtB+E7KGPH44lE+AqK2+3LSZAOKyafWIWjwJ4lt4w+JoyS/td4C0fosCczhh lyog3MOkWAxpMGFP68yD7B+7WCc8xiQWW7EhuKiTeIuP7TKS3vkgJkXBWdvB3984VPIh CdWg== X-Gm-Message-State: AOJu0YyN5yGdPn3KDCNITryQkKJVDMNVJIE4yRjnX/31eUbMVS+DPrcK W/vcHUnR0rVhJgcmY/QmV5fxKOivxSCHt+c3LSksiyqM5TfaqgoZ X-Gm-Gg: ASbGnctb0PIVvCscRJXHSCOC5o+d3vP7ezk3PL88mNzYaPI55rfhCBP/6ScQROFTu8S FPjNRCsniAqCmr+nn8QYo3libxuuK+BFk4QHVx3j5YsU8iIA5bsPWXZ34WUBdIfhBVAebZwsSSa IvZqKdBlwfMSUx0cqK5KToBCRNDqFQUU3PLRNvx7O+2PiUW/Su4tP39Bq9Kn8FeQpFAAqT7Lcbg seCJPAKl8ErD0KV+WGysYaMB11sPLGevFG7ZxYxlIZAOZNqElF6QXd2Zg== X-Google-Smtp-Source: AGHT+IEtaJ3oC0rAeyy9BllYy4IZihIRl7Gj9gX3BTVxYSn5pJ/FBigLfbZmavQG/68G/fXhcevPNQ== X-Received: by 2002:a05:600c:4fc9:b0:432:cbe5:4f09 with SMTP id 5b1f17b1804b1-434ddead99dmr7055485e9.4.1733433599010; Thu, 05 Dec 2024 13:19:59 -0800 (PST) Original-Received: from mba ([151.56.36.113]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-386219098c8sm2996903f8f.77.2024.12.05.13.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2024 13:19:58 -0800 (PST) In-Reply-To: <878qsu3zln.fsf@posteo.net> Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=filippo.argiolas@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326104 Archived-At: Philip Kaludercic writes: > Filippo Argiolas writes: > >> Philip Kaludercic writes: >> >>> Filippo Argiolas writes: >>> >>>> Filippo Argiolas writes: >>>> >>>>> Philip Kaludercic writes: >>>>> >>>>>> I would try something of the form like >>>>>> >>>>>> (if (fboundp 'new-function) >>>>>> (new-function ...) >>>>>> (old-function ...)) >>>>>> >>>>>> If on the other hand there has already been a new release of Eglot w= ith >>>>>> these commands, then just depend on that version and the issue would >>>>>> resolve itself. >>>>>> >>>>> >>>>> CC-ing Jo=C3=A3o. >>>>> >>>>> I pushed the suggested change but I still get the compile warnings ab= out >>>>> deprecated functions. I'd like to keep supporting emacs-29, should I >>>>> just disregard the warning? >>>>> >>>>> Sorry for the ignorance, how would the dependency on a specific eglot >>>>> version work now that it's in core? >>>>> Does it require the users to have additional repos enabled? >>>>> >>>>> Sounds strange to me that we have macros to deprecate functions but no >>>>> mechanism to automatically switch to the new one if it's just a >>>>> rename. Am I missing something obvious? >>>>> >>>>> Thanks! >>>>> >>>>> Filippo >>>> >>>> How about something like: >>>> >>>> ;; fallback to deprecated eglot functions >>>> (when (version< emacs-version "30") >>>> (defalias 'eglot-uri-to-path 'eglot--uri-to-path) >>>> (defalias 'eglot-range-region 'eglot--range-region)) >>>> >>>> or even something similar with a check on eglot version? >>> >>> That can be dangerous if other packages do fboundp checks and infer too >>> much from that. I would try to see if adding `declare-function's could >>> help suppress the warnings? >> >> Nope, the only solution working so far is to call the deprecated >> functions with `with-no-warnings'. >> >> Guess I'll go with this. I'd be fine with the warnings too if we didn't >> have the annoying habit of scaring the end users with them :-) > > I don't have your source code available right now, my last suggestion > would be to use `with-suppressed-warnings' where you can suppress > specific obsoletion warnings, but that requires Emacs 27.1 or newer. > Thanks this seems to do the trick! Filippo