From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames' Date: Thu, 19 Dec 2024 14:19:20 +0100 Message-ID: References: <173459970775.288909.12887171645975658795@vcs3.savannah.gnu.org> <20241219091511.B84DEC022CC@vcs3.savannah.gnu.org> <87ikrflx8s.fsf@gmx.de> <868qsblu13.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19603"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: michael.albinus@gmx.de, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 19 14:21:09 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOGSh-0004pV-Mr for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Dec 2024 14:21:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOGS3-0001y6-DZ; Thu, 19 Dec 2024 08:20:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOGR4-0001ny-Kq for emacs-devel@gnu.org; Thu, 19 Dec 2024 08:19:26 -0500 Original-Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOGR3-0004fL-1p; Thu, 19 Dec 2024 08:19:26 -0500 Original-Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-aab6fa3e20eso132237766b.2; Thu, 19 Dec 2024 05:19:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734614362; x=1735219162; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LL8Rq3cnf/5jfBOBP10sJDlaAxjbjulPXB4RsP5L46o=; b=WtzFhY7m660LPx7H+itDxvAbaE5U4n7Zc2NcaVCHuA134hTFB1w0OruJmIjjWAjZQY efFOEtyJVNam+DQH7pXa+y88zYA3kjzJYkRYtY61F4Y/y9jiDoWk5K0CNL2rebdkwARl j9HLhAkrJBIm1pdBuM6eKtjvtW1+vbIwPmBdteVKPx+VmpAKHEvF/gJJocBW7sO8JDg5 gI29XeJ1irwgOiy59ekPLTpc9L+Smtqc/QvEvP3NgLt39mSeQtUeK1XSnz7CldC3v9OH QDA1EclAhlHnceFNEsF+CPYtU51xv3K/RTCIpxUP/W9nbPMX/ucOSCA1OqRa0XkG7Rqq Qkwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734614362; x=1735219162; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LL8Rq3cnf/5jfBOBP10sJDlaAxjbjulPXB4RsP5L46o=; b=pGbe4SiYiL6xatgmqxmXCZLStIYEXfOGIEhHLTLgfurkOdI4yl2hZ6rb71WY7twUiQ AtVvLEOiDIRIS9wm664ri/ueHmvU2J+DRj3X67D6nXZVQIf7BfRV+pn94Lxngtx7esJA WTemzYc1ei99j3fbqbbDDdbVKTsVrgK8E8e9uXIOz8A2lrWiDSnqIDtqY+439d1apZY0 I3hqN9PxoguwWKORFq1zGPgqUoQdzu4EIZLed1wu23uumz5gNMF4msV9/IPxTfsq66hk vKO2X1V+TPDUTRh1D1DH0P24rhUcJkr9GI/gEe936Hu3mKu4O1azV4Bpq6cRp+oO3y/O PAYQ== X-Forwarded-Encrypted: i=1; AJvYcCWpZrOn1VLAm1kAvmLO1sCMZRj+SCj8cKwAAhC8wm7JMI14Dh6212J2Ssm5S35OJsBBNcxDwnoPwZBzXA==@gnu.org X-Gm-Message-State: AOJu0YyJylhroXQsc+qI6plra5MQZDEvYcfXZRQqELHApK3wZpdtnJt/ fcy75tkfzjhLqPBW0Py0pliS1JTm+6ZZ7A1FX9jC4zJOWJZMNr9cqJNNHg== X-Gm-Gg: ASbGncum/kwD6OznSRYHMEKC55u98XFU3eciRmhwBZj3yICP/0V11Lgrvv4JadtGS8P mTi67dScvJFX6lZ/2iRgDoOVkKm9O05CmhyH29F7ZQVJQz+nKcz+ftZh3s7AUG+Cqvq6nxrH3pr eCOM1ysk98HobGBdox53lWREPYihPY7YePvuaoHAibJLHT3CqHMKrnm4dK8qBX263JvtUMpNjI5 zODXbNsYj+WkhTv96IOvT3VHfpwRnExwrvRbSBgUP02RY7hq0ZlWopY0Nhg138CgMRQhHypgNzR b/Qd1NSLYtf/wJ1HRITbgk8EAwjZmzDrWyh/c4g21I+ziG8HZr0sFSOZhSawBo4mWA== X-Google-Smtp-Source: AGHT+IEYIw8huCc4NR6V8gSKPgqTXTguGVUvMKPF1IsmlaO/nRTrN4ez7rbQe7zZcR+AUUTt6+G4lQ== X-Received: by 2002:a17:907:9690:b0:aa6:7165:5044 with SMTP id a640c23a62f3a-aabf48f76c9mr501437166b.44.1734614361992; Thu, 19 Dec 2024 05:19:21 -0800 (PST) Original-Received: from pro2 (p200300e0b73f530035e1461ed45ebc64.dip0.t-ipconnect.de. [2003:e0:b73f:5300:35e1:461e:d45e:bc64]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0f015b3csm64060066b.161.2024.12.19.05.19.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2024 05:19:21 -0800 (PST) In-Reply-To: <868qsblu13.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 Dec 2024 14:46:48 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326741 Archived-At: Eli Zaretskii writes: >> From: Gerd M=C3=B6llmann >> Cc: emacs-devel@gnu.org >> Date: Thu, 19 Dec 2024 12:59:44 +0100 >>=20 >> Michael Albinus writes: >>=20 >> > Gerd Moellmann writes: >> > >> > Hi Gerd, >> > >> >> Merge branch 'scratch/tty-child-frames' >> >> >> >> Add support for child frames on tty >> > >> > This breaks xt-mouse-tests: >> > >> > --8<---------------cut here---------------start------------->8--- >> > # make -C test xt-mouse-tests >> > Test xt-mouse-tracking-basic condition: >> > (error "tty frame should be used") >> > FAILED 1/3 xt-mouse-tracking-basic (0.776520 sec) at lisp/xt-mous= e-tests.el:61 >> > Test xt-mouse-tracking-sgr condition: >> > (error "tty frame should be used") >> > FAILED 2/3 xt-mouse-tracking-sgr (0.000466 sec) at lisp/xt-mouse-= tests.el:102 >> > Test xt-mouse-tracking-utf-8 condition: >> > (error "tty frame should be used") >> > FAILED 3/3 xt-mouse-tracking-utf-8 (0.000746 sec) at lisp/xt-mous= e-tests.el:80 >> > --8<---------------cut here---------------end--------------->8--- >> > >> > Best regards, Michael. >>=20 >> Hi Michael, >>=20 >> The new code now _requires_ a tty frame to be used (decode_tty_frame, >> check_tty), which I think the tests can't provide, running in batch. And >> I'd rather not be less picky for the sake of these tests. > > Why is that a problem?=20=20 You mean why removing the checks (decode_tty_frame, check_tty) is a problem?. My question is more what these tests bring tot he table that outweighs removing checks. =20 > A batch session does have a frame, you just need to account for that. I know it has an initial frame, which is neither a tty nor a window system frame. The idea of testing xt-mouse with that is, let's say, interesting. And then that comment ;; FIXME: this doesn't work when called inside a non-batch mode Emacs ;; session. > I think the test that emits the error is too strict, and should be > relaxed when noninteractive is non-zero. Or maybe invert the test and > check for !FRAME_WINDOW_P (which would then allow the frame that > exists in the batch session). I could maybe make check_tty not signal if noninteractive =3D=3D true. I guess that could make things work, one has to try, but it surely doesn't win a beauty price :-(.