* Typo?: (gnus-topic-find-topology topic nil nil gnus-topic-topology)
@ 2011-12-30 9:33 Leo
2012-01-03 19:49 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Leo @ 2011-12-30 9:33 UTC (permalink / raw)
To: emacs-devel
This line in gnus-topic-kill-group (gnus-topic.el) seems problematic. Is
it a typo?
(gnus-topic-find-topology topic nil nil gnus-topic-topology)
where the signature of gnus-topic-find-topology is:
(gnus-topic-find-topology TOPIC &optional TOPOLOGY LEVEL REMOVE)
Leo
================ PATCH ================
--- a/gnus/gnus-topic.el
+++ b/gnus/gnus-topic.el
@@ -1368,7 +1368,7 @@
(assoc topic gnus-topic-alist))
gnus-topic-killed-topics)
(gnus-topic-remove-topic nil t)
- (gnus-topic-find-topology topic nil nil gnus-topic-topology)
+ (gnus-topic-find-topology topic)
(gnus-topic-enter-dribble))
(gnus-group-kill-group n discard)
(if (not (gnus-group-topic-p))
Diff finished. Fri Dec 30 17:32:51 2011
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Typo?: (gnus-topic-find-topology topic nil nil gnus-topic-topology)
2011-12-30 9:33 Typo?: (gnus-topic-find-topology topic nil nil gnus-topic-topology) Leo
@ 2012-01-03 19:49 ` Lars Magne Ingebrigtsen
2012-01-04 1:12 ` Leo
0 siblings, 1 reply; 3+ messages in thread
From: Lars Magne Ingebrigtsen @ 2012-01-03 19:49 UTC (permalink / raw)
To: Leo; +Cc: emacs-devel
Leo <sdl.web@gmail.com> writes:
> This line in gnus-topic-kill-group (gnus-topic.el) seems problematic. Is
> it a typo?
>
> (gnus-topic-find-topology topic nil nil gnus-topic-topology)
>
> where the signature of gnus-topic-find-topology is:
>
> (gnus-topic-find-topology TOPIC &optional TOPOLOGY LEVEL REMOVE)
Yes, so if `gnus-topic-topology' is non-nil, the topology in question
will be removed. Which seems natural for `gnus-topic-kill-group', I
think. Unless I'm misreading the code.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Typo?: (gnus-topic-find-topology topic nil nil gnus-topic-topology)
2012-01-03 19:49 ` Lars Magne Ingebrigtsen
@ 2012-01-04 1:12 ` Leo
0 siblings, 0 replies; 3+ messages in thread
From: Leo @ 2012-01-04 1:12 UTC (permalink / raw)
To: emacs-devel
On 2012-01-04 03:49 +0800, Lars Magne Ingebrigtsen wrote:
> Yes, so if `gnus-topic-topology' is non-nil, the topology in question
> will be removed. Which seems natural for `gnus-topic-kill-group', I
> think. Unless I'm misreading the code.
Agree.
Leo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-04 1:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-30 9:33 Typo?: (gnus-topic-find-topology topic nil nil gnus-topic-topology) Leo
2012-01-03 19:49 ` Lars Magne Ingebrigtsen
2012-01-04 1:12 ` Leo
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).