unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo <sdl.web@gmail.com>
To: emacs-devel@gnu.org
Subject: Typo?: (gnus-topic-find-topology topic nil nil gnus-topic-topology)
Date: Fri, 30 Dec 2011 17:33:57 +0800	[thread overview]
Message-ID: <m1zkeafloa.fsf@gmail.com> (raw)

This line in gnus-topic-kill-group (gnus-topic.el) seems problematic. Is
it a typo?

   (gnus-topic-find-topology topic nil nil gnus-topic-topology)

where the signature of gnus-topic-find-topology is:

   (gnus-topic-find-topology TOPIC &optional TOPOLOGY LEVEL REMOVE)

Leo

================ PATCH ================

--- a/gnus/gnus-topic.el
+++ b/gnus/gnus-topic.el
@@ -1368,7 +1368,7 @@
 	       (assoc topic gnus-topic-alist))
 	      gnus-topic-killed-topics)
 	(gnus-topic-remove-topic nil t)
-	(gnus-topic-find-topology topic nil nil gnus-topic-topology)
+	(gnus-topic-find-topology topic)
 	(gnus-topic-enter-dribble))
     (gnus-group-kill-group n discard)
     (if (not (gnus-group-topic-p))

Diff finished.  Fri Dec 30 17:32:51 2011




             reply	other threads:[~2011-12-30  9:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-30  9:33 Leo [this message]
2012-01-03 19:49 ` Typo?: (gnus-topic-find-topology topic nil nil gnus-topic-topology) Lars Magne Ingebrigtsen
2012-01-04  1:12   ` Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1zkeafloa.fsf@gmail.com \
    --to=sdl.web@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).