From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 73c1252bb6b: Fix link to major mode variable in docstring Date: Mon, 08 Jul 2024 11:34:18 +0200 Message-ID: References: <171956993509.30805.5525504753117432129@vcs2.savannah.gnu.org> <20240628101855.7E69DC2BC60@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21366"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Kangas To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 08 11:35:16 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQkmC-0005AF-8a for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Jul 2024 11:35:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQklN-0006wj-Vf; Mon, 08 Jul 2024 05:34:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQklM-0006vb-GX for emacs-devel@gnu.org; Mon, 08 Jul 2024 05:34:24 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQklK-0006tH-Vz for emacs-devel@gnu.org; Mon, 08 Jul 2024 05:34:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1720431260; bh=iPF3NIfbwZQXgA36FK2qNPuD9nmDJQy14+YwNEXjLic=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FXyA7T8zYTbSGAcsR++vtCVqw8UnbiJwnNui/OLt8vyLqLehTvOVr+rlYQRL7IbJ2 lgAh7iiXNT+TQpYEaNJZ9VS/zhzKS56zJQZNEuamDdLSsUlgXZeivdrFPBYMZVjF8/ ih++ZatbnUCwL+AHxll8uJhWznG0yedSwaf3x6KA8+1g4WQdwcIaUO2xXiDljjISoy 7TAgTdbyDSc5KXPJQq9eheGSpi4BBKJbTV2oe8mdn9ZZeJgyOJfv+4qSnIObCB1OCd S7DfjStNhBvRve2g0ReUmHOO3jEH0xbo1xnoviQMdytPDG293S+6e0GiIdoNC2xJrv FU1V5mzUKdJug== In-Reply-To: <20240628101855.7E69DC2BC60@vcs2.savannah.gnu.org> (Stefan Kangas's message of "Fri, 28 Jun 2024 06:18:55 -0400 (EDT)") Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321531 Archived-At: Hi Stefan, Stefan Kangas writes: > branch: emacs-30 > commit 73c1252bb6b7cc61d9f992818568d3c57de4ff67 > Author: Stefan Kangas > Commit: Stefan Kangas > > Fix link to major mode variable in docstring >=20=20=20=20=20 > * lisp/emacs-lisp/easy-mmode.el (easy-mmode--arg-docstring): Fix link= to > major mode variable in docstring. (Bug#71815) > --- > lisp/emacs-lisp/easy-mmode.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el > index ba0f8bad393..12712cb2bc3 100644 > --- a/lisp/emacs-lisp/easy-mmode.el > +++ b/lisp/emacs-lisp/easy-mmode.el > @@ -91,7 +91,7 @@ Enable the mode if ARG is nil, omitted, or is a positiv= e number. > Disable the mode if ARG is a negative number. >=20=20 > To check whether the minor mode is enabled in the current buffer, > -evaluate `%s'. > +evaluate the variable `%s'. >=20=20 > The mode's hook is called both when the mode is enabled and when > it is disabled.") I think it's not always correct to say "the variable" here, because that "%s" may be replaced with a form that's not just a variable. E.g. now C-h f global-auto-revert-mode RET says: To check whether the minor mode is enabled in the current buffer, evaluate the variable =E2=80=98(default-value 'global-auto-revert-mode)= =E2=80=99. Best, Eshel