Re: emacs-30 73c1252bb6b: Fix link to major mode variable in docstring

[Eshel Yaron <me@eshelyaron.com>]

Hi Stefan,

Stefan Kangas <stefankangas@gmail.com> writes:

> branch: emacs-30
> commit 73c1252bb6b7cc61d9f992818568d3c57de4ff67
> Author: Stefan Kangas <stefankangas@gmail.com>
> Commit: Stefan Kangas <stefankangas@gmail.com>
>
>     Fix link to major mode variable in docstring
>     
>     * lisp/emacs-lisp/easy-mmode.el (easy-mmode--arg-docstring): Fix link to
>     major mode variable in docstring.  (Bug#71815)
> ---
>  lisp/emacs-lisp/easy-mmode.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el
> index ba0f8bad393..12712cb2bc3 100644
> --- a/lisp/emacs-lisp/easy-mmode.el
> +++ b/lisp/emacs-lisp/easy-mmode.el
> @@ -91,7 +91,7 @@ Enable the mode if ARG is nil, omitted, or is a positive number.
>  Disable the mode if ARG is a negative number.
>  
>  To check whether the minor mode is enabled in the current buffer,
> -evaluate `%s'.
> +evaluate the variable `%s'.
>  
>  The mode's hook is called both when the mode is enabled and when
>  it is disabled.")

I think it's not always correct to say "the variable" here, because that
"%s" may be replaced with a form that's not just a variable.  E.g. now
C-h f global-auto-revert-mode RET says:

  To check whether the minor mode is enabled in the current buffer,
  evaluate the variable ‘(default-value 'global-auto-revert-mode)’.


Best,

Eshel