unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eshel Yaron <me@eshelyaron.com>
To: emacs-devel@gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: Re: emacs-30 8064b2a6798: Document undocumented completion commands
Date: Sun, 05 Jan 2025 09:06:04 +0100	[thread overview]
Message-ID: <m1zfk5sn0z.fsf@macbookpro.home> (raw)
In-Reply-To: <20241224192621.31046CA6ED0@vcs3.savannah.gnu.org> (Eli Zaretskii's message of "Tue, 24 Dec 2024 14:26:20 -0500 (EST)")

Hi,

Eli Zaretskii <eliz@gnu.org> writes:

> branch: emacs-30
> commit 8064b2a67988e815c52e289fe2a235ce1008776f
> Author: Eli Zaretskii <eliz@gnu.org>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
>     Document undocumented completion commands

Thanks for this.

> diff --git a/src/minibuf.c b/src/minibuf.c
> index f16880011f7..83b1fa024f8 100644
> --- a/src/minibuf.c
> +++ b/src/minibuf.c
> @@ -1293,6 +1293,11 @@ barf_if_interaction_inhibited (void)
>  DEFUN ("read-from-minibuffer", Fread_from_minibuffer,
>         Sread_from_minibuffer, 1, 7, 0,
>         doc: /* Read a string from the minibuffer, prompting with string PROMPT.
> +While in the minibuffer, you can use \\<minibuffer-local-completion-map>\\[minibuffer-complete] and \\[minibuffer-complete-word] to complete your input.
> +You can also use \\<minibuffer-local-map>\\[minibuffer-complete-history] to complete using history items in the
> +input history HIST, and you can use \\[minibuffer-complete-defaults] to complete using
> +the default items in DEFAULT-VALUE.
> +
>  The optional second arg INITIAL-CONTENTS is an obsolete alternative to
>    DEFAULT-VALUE.  It normally should be nil in new code, except when
>    HIST is a cons.  It is discussed in more detail below.

This part isn't quite right: read-from-minibuffer does not provide
completion with minibuffer-complete[-word] by default.

How about just dropping these references?  Something like:

diff --git a/src/minibuf.c b/src/minibuf.c
index 6ac3216a62f..becc3a9f26c 100644
--- a/src/minibuf.c
+++ b/src/minibuf.c
@@ -1297,8 +1297,7 @@ barf_if_interaction_inhibited (void)
 DEFUN ("read-from-minibuffer", Fread_from_minibuffer,
        Sread_from_minibuffer, 1, 7, 0,
        doc: /* Read a string from the minibuffer, prompting with string PROMPT.
-While in the minibuffer, you can use \\<minibuffer-local-completion-map>\\[minibuffer-complete] and \\[minibuffer-complete-word] to complete your input.
-You can also use \\<minibuffer-local-map>\\[minibuffer-complete-history] to complete using history items in the
+While in the minibuffer, you can use \\<minibuffer-local-map>\\[minibuffer-complete-history] to complete using history items in the
 input history HIST, and you can use \\[minibuffer-complete-defaults] to complete using
 the default items in DEFAULT-VALUE.
 



       reply	other threads:[~2025-01-05  8:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <173506838079.2264184.7348874799811402829@vcs3.savannah.gnu.org>
     [not found] ` <20241224192621.31046CA6ED0@vcs3.savannah.gnu.org>
2025-01-05  8:06   ` Eshel Yaron [this message]
2025-01-05  9:15     ` emacs-30 8064b2a6798: Document undocumented completion commands Eli Zaretskii
2025-01-05 11:36       ` Eshel Yaron
2025-01-05 12:11         ` Eli Zaretskii
2025-01-06 12:16           ` Eshel Yaron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1zfk5sn0z.fsf@macbookpro.home \
    --to=me@eshelyaron.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).