unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: defface location in describe-face
Date: Tue, 04 Jan 2005 09:26:45 -0500	[thread overview]
Message-ID: <m1wtutp92a.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20050104022247.8315.qmail@web25809.mail.ukl.yahoo.com> (drkm's message of "Tue, 4 Jan 2005 03:22:47 +0100 (CET)")

> replaced by (locally binding `find-variable-regexp'):

>     (let ((library (or file (symbol-file face 'defface)))
>           (find-variable-regexp find-face-regexp))
>       (find-function-search-for-symbol face 'variable library)))

That's ugly.

>   But I think `find-func' library should be fixed to handle arbitrary
> kind of symbol (or at least other standard things than functions and
> variables).

Yes, that's what needs to be done.

The rest of the patch looks OK, except that the "loaddefs.el" thingy should
be removed (it's only done for variables, not for functions, and shouldn't
be done for faces either).


        Stefan

  reply	other threads:[~2005-01-04 14:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-04  2:22 defface location in describe-face drkm
2005-01-04 14:26 ` Stefan [this message]
2005-01-04 16:42   ` drkm
  -- strict thread matches above, loose matches on Subject: below --
2005-01-04  2:15 drkm
2005-01-04  2:06 drkm
2005-01-05  3:31 ` Richard Stallman
2005-01-05  4:34   ` drkm
2005-01-03 21:13 drkm
2005-01-03 22:08 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1wtutp92a.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).