From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: master ff3f17ca3cd: choose-completion: Retain the suffix after completion boundary Date: Fri, 10 May 2024 18:10:48 +0200 Message-ID: References: <171522198055.22327.4428936546182324178@vcs2.savannah.gnu.org> <20240509023301.A25B3C1F9DE@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2602"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 10 18:11:41 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s5SqS-0000Uz-Ve for ged-emacs-devel@m.gmane-mx.org; Fri, 10 May 2024 18:11:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s5Spj-0008Be-Ju; Fri, 10 May 2024 12:10:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5Sph-0008At-RJ for emacs-devel@gnu.org; Fri, 10 May 2024 12:10:53 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5Spg-0002gU-5c for emacs-devel@gnu.org; Fri, 10 May 2024 12:10:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1715357450; bh=uTuG0SDBom8ENGAgd8okg47uzwcbw+/zlcQU0nWoAbc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=SXj5PkMpxsmZoeNKEOlWFllAlUq5xnDKVX/iU7+lFDgsw8+xIM+63S/ZSZ0aN5XQ4 is/pOtRFLvCRHyIWYTeCRMxNLLFarX2o2sEW+5PhaHNLQCPNukwoYJTeVRaKaNjuA7 sWtDBnzMGPiDpIaG6VwhTYrNtePsZGWR/Bg4g/J1lcpx+dAAf7BoMQxldlYjXDx4EN +gW0i5w9usshyEJZZObq74fLPceIbhNrWKvsN9JCg9FUy1HPb2RTHBw8oHNI1dI3GP /oRRW4397i/XrdPR6fDs5kQVdgCnMVQT/GuIlULTzrYkRmMkL1rSejp50fd5w9nd1+ s5jS9tzeqUc0Q== In-Reply-To: <20240509023301.A25B3C1F9DE@vcs2.savannah.gnu.org> (Dmitry Gutov's message of "Wed, 8 May 2024 22:33:00 -0400 (EDT)") Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319147 Archived-At: Hi Dmitry, Dmitry Gutov writes: > branch: master > commit ff3f17ca3cdd9e82355942f577e7807acc76ddcd > Author: Dmitry Gutov > Commit: Dmitry Gutov > > choose-completion: Retain the suffix after completion boundary > > * lisp/minibuffer.el (completion-base-suffix): > Remove as not optimal after all (bug#48356). > (completion--replace): Use insert-before-markers-and-inherit. [...] > - (insert-and-inherit newtext) > + (insert-before-markers-and-inherit newtext) It seems that this change breaks the cycling behavior of minibuffer-force-complete. You can see the problem by saying: 1. emacs -Q 2. (setq completion-cycle-threshold t) 3. Open some buffers 4. C-x b TAB TAB TAB ... The repeated TAB presses are expected to cycle through the completion candidates (this is the behavior in Emacs 29 for example) but now each TAB appends to the minibuffer input instead of replacing it. Best, Eshel