From: Eshel Yaron <me@eshelyaron.com>
To: emacs-devel@gnu.org
Cc: Dmitry Gutov <dmitry@gutov.dev>
Subject: Re: master ff3f17ca3cd: choose-completion: Retain the suffix after completion boundary
Date: Fri, 10 May 2024 18:10:48 +0200 [thread overview]
Message-ID: <m1wmo1ve9j.fsf@dazzs-mbp.kpn> (raw)
In-Reply-To: <20240509023301.A25B3C1F9DE@vcs2.savannah.gnu.org> (Dmitry Gutov's message of "Wed, 8 May 2024 22:33:00 -0400 (EDT)")
Hi Dmitry,
Dmitry Gutov <dgutov@yandex.ru> writes:
> branch: master
> commit ff3f17ca3cdd9e82355942f577e7807acc76ddcd
> Author: Dmitry Gutov <dmitry@gutov.dev>
> Commit: Dmitry Gutov <dmitry@gutov.dev>
>
> choose-completion: Retain the suffix after completion boundary
>
> * lisp/minibuffer.el (completion-base-suffix):
> Remove as not optimal after all (bug#48356).
> (completion--replace): Use insert-before-markers-and-inherit.
[...]
> - (insert-and-inherit newtext)
> + (insert-before-markers-and-inherit newtext)
It seems that this change breaks the cycling behavior of
minibuffer-force-complete. You can see the problem by saying:
1. emacs -Q
2. (setq completion-cycle-threshold t)
3. Open some buffers
4. C-x b TAB TAB TAB ...
The repeated TAB presses are expected to cycle through the completion
candidates (this is the behavior in Emacs 29 for example) but now each
TAB appends to the minibuffer input instead of replacing it.
Best,
Eshel
next parent reply other threads:[~2024-05-10 16:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171522198055.22327.4428936546182324178@vcs2.savannah.gnu.org>
[not found] ` <20240509023301.A25B3C1F9DE@vcs2.savannah.gnu.org>
2024-05-10 16:10 ` Eshel Yaron [this message]
2024-05-12 2:59 ` master ff3f17ca3cd: choose-completion: Retain the suffix after completion boundary Dmitry Gutov
2024-05-12 12:38 ` Eshel Yaron
2024-05-12 16:03 ` Dmitry Gutov
2024-05-13 6:35 ` Eshel Yaron
2024-05-17 8:56 ` Eshel Yaron
2024-05-17 23:28 ` Dmitry Gutov
2024-05-18 6:55 ` Eshel Yaron
2024-05-18 13:33 ` Dmitry Gutov
2024-05-18 13:51 ` Eshel Yaron
2024-05-18 14:18 ` Dmitry Gutov
2024-05-29 10:05 ` Eshel Yaron
2024-05-29 10:37 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1wmo1ve9j.fsf@dazzs-mbp.kpn \
--to=me@eshelyaron.com \
--cc=dmitry@gutov.dev \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).