unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eshel Yaron <me@eshelyaron.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-30 8064b2a6798: Document undocumented completion commands
Date: Mon, 06 Jan 2025 13:16:40 +0100	[thread overview]
Message-ID: <m1wmf8b0if.fsf@macbookpro.home> (raw)
In-Reply-To: <86frlx8np8.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 05 Jan 2025 14:11:47 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Eshel Yaron <me@eshelyaron.com>
>> Cc: emacs-devel@gnu.org
>> Date: Sun, 05 Jan 2025 12:36:27 +0100
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> >> From: Eshel Yaron <me@eshelyaron.com>
>> >> Cc: Eli Zaretskii <eliz@gnu.org>
>> >> Date: Sun, 05 Jan 2025 09:06:04 +0100
>> >> 
>> >> >  DEFUN ("read-from-minibuffer", Fread_from_minibuffer,
>> >> >         Sread_from_minibuffer, 1, 7, 0,
>> >> >         doc: /* Read a string from the minibuffer, prompting with string PROMPT.
>> >> > +While in the minibuffer, you can use \\<minibuffer-local-completion-map>\\[minibuffer-complete] and \\[minibuffer-complete-word] to complete your input.
>> >> 
>> >> This part isn't quite right: read-from-minibuffer does not provide
>> >> completion with minibuffer-complete[-word] by default.
>> >> 
>> >> How about just dropping these references?
>> >
>> > Sorry, I don't want to drop them, they are important.
>> >
>> > Why do you say these are not supported by default?  I can use them in
>> > "emacs -Q", so what did I miss?
>> 
>> Hmm, C-h f read-from-minibuffer now says "While in the minibuffer, you can
>> use TAB and SPC to complete your input."  But read-from-minibuffer doesn't
>> provide such completion, by default it uses minibuffer-local-map, in which
>> both keys are self-inserting.  Do you see something different?
>
> Please help me make this accurate without losing the important
> information about these commands.  Okay?

AFAICT it would be more accurate (and relevant) to mention these
commands in the docstring of completing-read, not read-from-minibuffer.
But they are also pretty well documented in both the Emacs manual and
the ELisp manual, so I'm not sure I see the importance of mentioning
them there as well...


Best,

Eshel



      reply	other threads:[~2025-01-06 12:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <173506838079.2264184.7348874799811402829@vcs3.savannah.gnu.org>
     [not found] ` <20241224192621.31046CA6ED0@vcs3.savannah.gnu.org>
2025-01-05  8:06   ` emacs-30 8064b2a6798: Document undocumented completion commands Eshel Yaron
2025-01-05  9:15     ` Eli Zaretskii
2025-01-05 11:36       ` Eshel Yaron
2025-01-05 12:11         ` Eli Zaretskii
2025-01-06 12:16           ` Eshel Yaron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1wmf8b0if.fsf@macbookpro.home \
    --to=me@eshelyaron.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).