From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Nicolas P. Rougier (inria)" Newsgroups: gmane.emacs.devel Subject: Re: ELPA: New package: nano-theme Date: Wed, 29 Sep 2021 07:07:40 +0200 Message-ID: References: <87bl4c6197.fsf@posteo.net> <8735po5ywp.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12395"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.6; emacs 27.2 Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 29 07:14:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVRus-00032U-BK for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 07:14:02 +0200 Original-Received: from localhost ([::1]:34752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVRur-0005b8-Cz for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 01:14:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVRtg-00045M-EE for emacs-devel@gnu.org; Wed, 29 Sep 2021 01:12:48 -0400 Original-Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:11324) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVRte-00073z-5i for emacs-devel@gnu.org; Wed, 29 Sep 2021 01:12:47 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3ARDf9MamslpvhYNWev+ESpWvv0+jpDfIW3DAb?= =?us-ascii?q?v31ZSRFFG/FwWfrAoB17726QtN9/YhAdcLy7VZWoYXSZ7pJt5JlUILHKZmnbUQ?= =?us-ascii?q?iTXeNfBOnZsl7d8kTFn4ZgPOVbGJSWY+efMbEVt6rHyTWjH81lyNeK973Av43j?= =?us-ascii?q?80s=3D?= X-IronPort-AV: E=Sophos;i="5.84,326,1620684000"; d="scan'208";a="530941790" Original-Received: from 91-160-114-139.subs.proxad.net (HELO M-E7-NPR) ([91.160.114.139]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2021 07:12:42 +0200 In-reply-to: <8735po5ywp.fsf@posteo.net> Received-SPF: pass client-ip=192.134.164.83; envelope-from=nicolas.rougier@inria.fr; helo=mail2-relais-roc.national.inria.fr X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275760 Archived-At: >>> Furthermore, I wonder why you define the commands nano-light >>> and >>> nano-dark, instead of two themes, nano-light and nano-dark >>> (along >>> the >>> same lines of what modus-themes currently does). You could >>> also turn >>> nano-setup into a custom theme, so that the user can easily >>> enable >>> and >>> disable it. >> >> Maybe I need to read the documentation on what a theme can >> set. For >> example, I set the face for the minibuffer (0 & 1) and echo >> area (0 & >> 1) and I wasn't sure how to specify this in a theme. Same for >> underline to be set at descent line, etc. > > Not directly, but you could define a custom option/minor mode > that is > activated as part of the theme to change these things too. But then you need to load the theme and activate the minor mode, do you?. Having a (nano-light) command is more direct in my opinion and in any case, user is free to only load the theme the regular way. >>> - Lines 363ff. seem to be indented unconventionally. Maybe add >>> a >>> .dir-locals.el to make sure everyone is using the same >>> whitespace >>> configuration. I had a mix of space and tabs for unknown reason. Hopefully it has been fixed. Nicolas