From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: autorevert.el Date: 23 Mar 2004 10:26:39 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <200403022319.i22NJbG01259@raven.dms.auburn.edu> <200403040508.i2458W811551@raven.dms.auburn.edu> <200403050400.i2540VQ21715@raven.dms.auburn.edu> <200403130310.i2D3A8w28676@raven.dms.auburn.edu> <200403150008.i2F083x04382@raven.dms.auburn.edu> <200403160456.i2G4uVL14097@raven.dms.auburn.edu> <2427-Tue16Mar2004214034+0200-eliz@elta.co.il> <200403190448.i2J4mxQ12087@raven.dms.auburn.edu> <200403210242.i2L2gSM28857@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1080057561 28345 80.91.224.253 (23 Mar 2004 15:59:21 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 23 Mar 2004 15:59:21 +0000 (UTC) Cc: eliz@elta.co.il, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Mar 23 16:59:06 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B5oIz-0006UI-00 for ; Tue, 23 Mar 2004 16:59:05 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1B5oIz-0003jE-00 for ; Tue, 23 Mar 2004 16:59:05 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B5oIk-0008Jf-3H for emacs-devel@quimby.gnus.org; Tue, 23 Mar 2004 10:58:50 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1B5oI4-0008HJ-CK for emacs-devel@gnu.org; Tue, 23 Mar 2004 10:58:08 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1B5oHW-0007xM-Pp for emacs-devel@gnu.org; Tue, 23 Mar 2004 10:58:07 -0500 Original-Received: from [206.47.199.164] (helo=simmts6-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B5oHV-0007w3-St for emacs-devel@gnu.org; Tue, 23 Mar 2004 10:57:33 -0500 Original-Received: from empanada.local ([67.68.216.177]) by simmts6-srv.bellnexxia.net (InterMail vM.5.01.06.05 201-253-122-130-105-20030824) with ESMTP id <20040323152638.ROVK7500.simmts6-srv.bellnexxia.net@empanada.local>; Tue, 23 Mar 2004 10:26:38 -0500 Original-Received: by empanada.local (Postfix, from userid 502) id BCF7C1412E6; Tue, 23 Mar 2004 10:26:39 -0500 (EST) Original-To: Luc Teirlinck In-Reply-To: <200403210242.i2L2gSM28857@raven.dms.auburn.edu> Original-Lines: 11 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:20799 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20799 > Here is the proposed patch. I actually took a look at the code > duplication in the current code and there appeared to be quite some. > My patch gets rid of one more function. Thanks, it looks pretty good. One thing tho: if you want to call the var buffer-stale-function, you have to defvar it in files.el or somesuch. If you defvar it in autorevert.el, you should call it auto-revert-stale-function or something. Stefan