From: Leo <sdl.web@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: [patch] add "underwave" face attribute
Date: Fri, 27 Jan 2012 12:01:33 +0800 [thread overview]
Message-ID: <m1ty3hlroi.fsf@gmail.com> (raw)
In-Reply-To: CA+5B0FM4gJ71Sdse8ZGcg++CV__gH3GonnfT01svkCBQkB_qzQ@mail.gmail.com
On 2012-01-27 01:55 +0800, Aurélien Aptel wrote:
> I implemented a new face attribute "underwave". It does exactly what
> this thread[1] asked for.
> It only works on X11 currently. I don't have a windows/mac machine to
> port this feature but it should be easy to do: just port the changes
> made to xterm.c to other *term.c. I've basically followed whatever
> "overline" was doing so it should be ok.
Thank you for taking the trouble to implement it. Looks nice.
> I've attached the diff and a screenshot of the splash screen with the
> default and link face changed to use underwaving. Note that it looks
> good on both X11 core fonts and Xft fonts.
>
> I would love to this this merged in emacs so -- if everything's
> alright -- what's the next step?
Probably submit the patch to the bug tracker M-x report-emacs-bug. Get
someone to review it.
Thanks again.
Leo
next prev parent reply other threads:[~2012-01-27 4:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 17:55 [patch] add "underwave" face attribute Aurélien Aptel
2012-01-27 4:01 ` Leo [this message]
2012-01-27 10:25 ` Andreas Schwab
2012-01-27 13:02 ` Aurélien Aptel
2012-01-27 14:06 ` Andreas Schwab
2012-01-27 14:55 ` Aurélien Aptel
2012-01-27 15:53 ` Andreas Schwab
-- strict thread matches above, loose matches on Subject: below --
2012-01-26 20:16 Aurélien Aptel
2012-01-27 15:50 ` Stefan Monnier
2012-01-27 17:08 ` Drew Adams
2012-01-31 23:38 ` Aurélien Aptel
2012-02-01 16:21 ` Leo
2012-02-01 23:11 ` Juri Linkov
2012-02-02 0:18 ` Aurélien Aptel
2012-02-02 0:52 ` Juanma Barranquero
2012-02-03 19:37 ` Aurélien Aptel
2012-02-04 8:14 ` Jan Djärv
2012-02-04 18:22 ` Aurélien Aptel
2012-02-06 0:18 ` Alp Aker
2012-02-06 0:24 ` Aurélien Aptel
2012-02-06 0:51 ` Alp Aker
2012-02-06 0:55 ` Aurélien Aptel
2012-02-06 1:14 ` Alp Aker
2012-02-06 11:27 ` Aurélien Aptel
2012-02-06 17:20 ` Aurélien Aptel
2012-02-12 11:19 ` Aurélien Aptel
2012-02-12 16:59 ` Stefan Monnier
2012-02-12 17:08 ` Leo
2012-02-12 17:29 ` Aurélien Aptel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1ty3hlroi.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).