Re: master d879c40f68c: * etc/NEWS: Mention it.

Re: master d879c40f68c: * etc/NEWS: Mention it.

[Eshel Yaron]

Hi,

Dmitry Gutov <dgutov@yandex.ru> writes:

> branch: master
> commit d879c40f68c078bdba15122e4e886a2052fbddf4

[...]

> +;;;###autoload
> +(defun project-find-file-in-root ()
> +  "..."
> +  (interactive)
> +  (let* ((pr (project-current t))
> +         (default-directory (project-root pr)))
> +    (call-interactively #'find-file)))

Nice addition, thanks!

Nitpick: I find the use of call-interactively with a constant argument
slightly awkward.  What do y'all think about a revision along the
following lines?

--8<---------------cut here---------------start------------->8---
;;;###autoload
(defun project-find-file-in-root (filename)
  "Edit file FILENAME.
Interactively, prompt for FILENAME, defaulting to the root directory of
the current project."
  (declare (interactive-only find-file))
  (interactive
   (list (read-file-name "Find project file: "
                         (project-root (project-current t)) nil
                         (confirm-nonexistent-file-or-buffer))))
  (find-file filename t))
--8<---------------cut here---------------end--------------->8---

Re: master d879c40f68c: * etc/NEWS: Mention it.

[Dmitry Gutov]

On 09/09/2024 11:42, Eshel Yaron wrote:
> Nitpick: I find the use of call-interactively with a constant argument
> slightly awkward.  What do y'all think about a revision along the
> following lines?

Yeah, I think that works too (the only real duplication is the call to 
confirm-nonexistent-file-or-buffer, that's minor).

> --8<---------------cut here---------------start------------->8---
> ;;;###autoload
> (defun project-find-file-in-root (filename)
>    "Edit file FILENAME.
> Interactively, prompt for FILENAME, defaulting to the root directory of
> the current project."
>    (declare (interactive-only find-file))
>    (interactive
>     (list (read-file-name "Find project file: "

Maybe "Find in root: "? The command variant doesn't necessarily show all 
project files, or only project files.

>                           (project-root (project-current t)) nil
>                           (confirm-nonexistent-file-or-buffer))))
>    (find-file filename t))

Re: master d879c40f68c: * etc/NEWS: Mention it.

[Spencer Baugh]

[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]

I'm fine with this change.  "Find file in root: " seems like it would be a
decent prompt.

On Mon, Sep 9, 2024 at 7:40 AM Dmitry Gutov <dmitry@gutov.dev> wrote:

> On 09/09/2024 11:42, Eshel Yaron wrote:
> > Nitpick: I find the use of call-interactively with a constant argument
> > slightly awkward.  What do y'all think about a revision along the
> > following lines?
>
> Yeah, I think that works too (the only real duplication is the call to
> confirm-nonexistent-file-or-buffer, that's minor).
>
> > --8<---------------cut here---------------start------------->8---
> > ;;;###autoload
> > (defun project-find-file-in-root (filename)
> >    "Edit file FILENAME.
> > Interactively, prompt for FILENAME, defaulting to the root directory of
> > the current project."
> >    (declare (interactive-only find-file))
> >    (interactive
> >     (list (read-file-name "Find project file: "
>
> Maybe "Find in root: "? The command variant doesn't necessarily show all
> project files, or only project files.
>
> >                           (project-root (project-current t)) nil
> >                           (confirm-nonexistent-file-or-buffer))))
> >    (find-file filename t))
>
>

[-- Attachment #2: Type: text/html, Size: 1684 bytes --]

Re: master d879c40f68c: * etc/NEWS: Mention it.

[Eshel Yaron]

Spencer Baugh <sbaugh@janestreet.com> writes:

> I'm fine with this change.  "Find file in root: " seems like it would be a decent prompt.
>
> On Mon, Sep 9, 2024 at 7:40 AM Dmitry Gutov <dmitry@gutov.dev> wrote:
>
>  On 09/09/2024 11:42, Eshel Yaron wrote:
>  > Nitpick: I find the use of call-interactively with a constant argument
>  > slightly awkward.  What do y'all think about a revision along the
>  > following lines?
>
>  Yeah, I think that works too (the only real duplication is the call to 
>  confirm-nonexistent-file-or-buffer, that's minor).
>
>  > --8<---------------cut here---------------start------------->8---
>  > ;;;###autoload
>  > (defun project-find-file-in-root (filename)
>  >    "Edit file FILENAME.
>  > Interactively, prompt for FILENAME, defaulting to the root directory of
>  > the current project."
>  >    (declare (interactive-only find-file))
>  >    (interactive
>  >     (list (read-file-name "Find project file: "
>
>  Maybe "Find in root: "? The command variant doesn't necessarily show all 
>  project files, or only project files.
>
>  >                           (project-root (project-current t)) nil
>  >                           (confirm-nonexistent-file-or-buffer))))
>  >    (find-file filename t))

Great, now done in 466db358772.


Thanks,

Eshel