From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.devel Subject: Re: Move sha1 to C? Date: Mon, 23 May 2011 16:44:53 +0800 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1306140321 2881 80.91.229.12 (23 May 2011 08:45:21 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 23 May 2011 08:45:21 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 23 10:45:17 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QOQlJ-0001vS-6R for ged-emacs-devel@m.gmane.org; Mon, 23 May 2011 10:45:17 +0200 Original-Received: from localhost ([::1]:45114 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOQlF-0008Fs-Pd for ged-emacs-devel@m.gmane.org; Mon, 23 May 2011 04:45:13 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:40289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOQlD-0008Fm-Aa for emacs-devel@gnu.org; Mon, 23 May 2011 04:45:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QOQlC-0006k4-DP for emacs-devel@gnu.org; Mon, 23 May 2011 04:45:11 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:56403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOQlC-0006jy-61 for emacs-devel@gnu.org; Mon, 23 May 2011 04:45:10 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QOQl9-0001qM-Ar for emacs-devel@gnu.org; Mon, 23 May 2011 10:45:07 +0200 Original-Received: from 123.114.36.240 ([123.114.36.240]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 23 May 2011 10:45:07 +0200 Original-Received: from sdl.web by 123.114.36.240 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 23 May 2011 10:45:07 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 20 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 123.114.36.240 Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7) Cancel-Lock: sha1:548sOXgsIlQtBy5/pfM7xA//6Po= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139638 Archived-At: On 2011-05-23 09:23 +0800, Stefan Monnier wrote: > Fine by me. 3 should also include "gut sha1.el's content" so that > loading it won't end up overwriting the C implementation with the old > Elisp code. In the patch attached in last post, feature sha1 is provided so (require 'sha1) should not load sha1.el but if people insist in using (load "sha1") then the primitive is overwritten. I hope this is OK. > >> Should the signature of sha1 stay as is or change to be similar to md5? >> (md5 OBJECT &optional START END CODING-SYSTEM NOERROR) > > I don't have any opinion on this. The only thing I consider important > is to signal an error if the hashed text contains any > non-byte character. OK. Leo