* No "From so-and-so" in ChangeLog
@ 2005-01-03 4:32 Richard Stallman
2005-01-03 17:56 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Richard Stallman @ 2005-01-03 4:32 UTC (permalink / raw)
Please do not *ever* write "From so-and-so" in a change log entry. If
someone else wrote the code you are installing, *always* put his name
in the header line of the change.
If the person did NOT write the code you are installing, then don't
ever put something in ChangeLog which could give people the idea that
he did! If you want to mention who suggested an idea, or who reported
a bug, always say explicitly "idea suggested by" or "bug reported by"
so that there is no doubt ten years in the future.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: No "From so-and-so" in ChangeLog
2005-01-03 4:32 No "From so-and-so" in ChangeLog Richard Stallman
@ 2005-01-03 17:56 ` Stefan Monnier
2005-01-04 3:36 ` Richard Stallman
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2005-01-03 17:56 UTC (permalink / raw)
Cc: emacs-devel
> Please do not *ever* write "From so-and-so" in a change log entry. If
> someone else wrote the code you are installing, *always* put his name
> in the header line of the change.
> If the person did NOT write the code you are installing, then don't
> ever put something in ChangeLog which could give people the idea that
> he did! If you want to mention who suggested an idea, or who reported
> a bug, always say explicitly "idea suggested by" or "bug reported by"
> so that there is no doubt ten years in the future.
Shouldn't we then change changelog-mode's font-lock rules?
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: No "From so-and-so" in ChangeLog
2005-01-03 17:56 ` Stefan Monnier
@ 2005-01-04 3:36 ` Richard Stallman
2005-01-04 14:28 ` Stefan
0 siblings, 1 reply; 5+ messages in thread
From: Richard Stallman @ 2005-01-04 3:36 UTC (permalink / raw)
Cc: emacs-devel
Shouldn't we then change changelog-mode's font-lock rules?
I don't know what rules it uses--maybe so.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: No "From so-and-so" in ChangeLog
2005-01-04 3:36 ` Richard Stallman
@ 2005-01-04 14:28 ` Stefan
2005-01-04 19:54 ` Richard Stallman
0 siblings, 1 reply; 5+ messages in thread
From: Stefan @ 2005-01-04 14:28 UTC (permalink / raw)
Cc: emacs-devel
> Shouldn't we then change changelog-mode's font-lock rules?
> I don't know what rules it uses--maybe so.
Here is the relevant excerpt from add-log.el:
;; Acknowledgements.
("\\(^\t\\| \\)\\(From\\|Patch\\(es\\)? by\\|Report\\(ed by\\| from\\)\\|Suggest\\(ed by\\|ion from\\)\\)"
2 'change-log-acknowledgement-face))
-- Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: No "From so-and-so" in ChangeLog
2005-01-04 14:28 ` Stefan
@ 2005-01-04 19:54 ` Richard Stallman
0 siblings, 0 replies; 5+ messages in thread
From: Richard Stallman @ 2005-01-04 19:54 UTC (permalink / raw)
Cc: emacs-devel
;; Acknowledgements.
("\\(^\t\\| \\)\\(From\\|Patch\\(es\\)? by\\|Report\\(ed by\\| from\\)\\|Suggest\\(ed by\\|ion from\\)\\)"
I guess the question is whether we want to highlight a usage
that other projects might be using.
I guess it can't hurt any project to replace "From" with something
more specific. So I will take it out.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-01-04 19:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-03 4:32 No "From so-and-so" in ChangeLog Richard Stallman
2005-01-03 17:56 ` Stefan Monnier
2005-01-04 3:36 ` Richard Stallman
2005-01-04 14:28 ` Stefan
2005-01-04 19:54 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).