From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Daniel_Mart=C3=ADn?= Newsgroups: gmane.emacs.devel Subject: Re: master ed84f24a21: Make `signal-process' allow completing over signal names Date: Mon, 27 Jun 2022 10:47:15 +0200 Message-ID: References: <165627647702.21409.11158107897633930882@vcs2.savannah.gnu.org> <20220626204757.57AB1C01685@vcs2.savannah.gnu.org> <87ilomewbp.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22631"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (darwin) Cc: emacs-devel@gnu.org, Lars Ingebrigtsen To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 27 10:52:10 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5kTZ-0005bb-A9 for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Jun 2022 10:52:09 +0200 Original-Received: from localhost ([::1]:42612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5kTY-0002CG-2g for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Jun 2022 04:52:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5kOy-0005HX-LI for emacs-devel@gnu.org; Mon, 27 Jun 2022 04:47:26 -0400 Original-Received: from sonic310-57.consmr.mail.ir2.yahoo.com ([77.238.177.30]:33731) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5kOw-0004OL-Gd for emacs-devel@gnu.org; Mon, 27 Jun 2022 04:47:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1656319639; bh=ieJPf7PhYFEDbv2ZgEErYNLc1I5g4xMbPYpSC7TvFQs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=q7PGblLFit4ztitfxhodF5K+e5XFHD7nAX2u4x4ezr12ylhty6DT9mY6xuJlXzqATpSV1cyP5STJHc859FlFsBctxmUEetcQmeXB2mvyuWZXHbt/c8WGd0N2aHFzIPORppRlIdjXNTjR/E9appF/LGSktIJG0QGIt1a4o9PT4gjI1wBQpGNgOXkF3w60p/l1vLT1Qy//rne1xiswRynYfDH8QNsoU+8PJwPZIy3zxhZ4EppjMBgBuAwe1T9IfLq12kEGab/1R1isRTJZSzYcW75Q1B21CGkY1aSJiyPFFKng826/Hbxx0rMQSkW1M7AEZ0XoutWGLixTKY2pyV+3XA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1656319639; bh=Mn3iH1F5XseZA8qDy77DTX8Wzi3x5qaFm7Lx2rNcBui=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=jjCkogLeeSm3ZOJhHDsbDqQ8F2Ud/gWQ02T36vUN2Z8S8wC3kLB/7o/uR+RIQNwgDXb0gvUl3mR70CvgIzgHYTfo8melmQCRQoy2+zxwGOGCN14u6REfUWOqE+BwiX1HUrYWetBL/7uitU7T3DYX955G9oHwM3aXGlBGdRLKe6xZ7bOHpD0n5u0EAk3r8fFTdb32CafXcyEnzdHyKnQvp/m8WkYP+YQdaKxRkAEHTvvK6EMYITXRoQqOC7ZcwUz23/2lK0oSVX06NCTPtjGXyN5K3YSc42haetYBARDbIdWeJ93b7qPMdk3CuXkO3K422EApG2aptvP2jnEemOlI7w== X-YMail-OSG: kEHULHQVM1loXbpRhVsALH8.3JyOwosh03hb71f.q6r4asSvgfnR4XUqLVLaRP. OoyCPaGjPlI2.gyf99JIBgVhMMQNwYUyBmG.Q20.TEIrlfU8lqOK8zy3jL8FYtf5RFJE3.GYNEz5 evLtCf8OfBKYuggZeq0k4ZwB04.hrerEjQwxjKGKzxBTGt9V6a.oOsVZPy_jLhScSLpsDlniGGPi xcS08f7bDt0dIgCHlmEOn1WN_rHsrN.thmTNm.G.6RXWdF274pQbD8kM6IEH9Qr1HgXAiuceenvT 1zSmhYJNz6rXabFNrOmXvyh5m7jjt2oig18CuaUxGM8RkWbTLvVXYT8a6iLLDG7SE627I1zRocnn CDec7_ivGzFFuzO0l.BHTCMHkJd7TIvdePexQkaBfc7W5RrrwXilego9a_xFYS_hfZisxQaITbkr L74afBTYS7F3Fj76cGqnhc_bQxA3dEy0UB1d5kcV.9HtSDk0yb4lyik6BGsu6P1.wSh3FMCYfq1Z F_RwvNpXFk9Wu7_V9IkzpxjCDfZYQcqpZT0qSZ4fRBnKZu541UXL5wPh.08Er3lSYNzuz_RnCwz_ QxQSZcQ0szJYGDSMHOF8UzvyH88EagXiFEiNA2xCydVV_NM37FS6R9UH8BflCjy6X6l4XVeQAxgr XfviwJxnXbgjaR.CuUKaNW9HCtF_TsX3BkTsdhPrbRlPC73P8xndJlAyMltLSbQxVRqzFEFqrUvM CbBfQ2olm9nyDP8zmYg_6Ob7Ii944BsIDxoPIR1RCezIJw41Q0l2IeelHAGDxQ8yn8Il2JlJkQL4 AWuWlnAfmnRF9zvfLYIVp4eKhdLwXt2_4tnF3DikTW X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Mon, 27 Jun 2022 08:47:19 +0000 Original-Received: by hermes--canary-production-ir2-c9bf9d9bc-fw6gn (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f1b5137a8e068dfbf3aeec8e8d07b603; Mon, 27 Jun 2022 08:47:16 +0000 (UTC) In-Reply-To: <87ilomewbp.fsf@yahoo.com> (Po Lu's message of "Mon, 27 Jun 2022 09:20:26 +0800") X-Mailer: WebService/1.1.20280 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=77.238.177.30; envelope-from=mardani29@yahoo.es; helo=sonic310-57.consmr.mail.ir2.yahoo.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291650 Archived-At: Po Lu writes: > Lars Ingebrigtsen writes: > >> +DEFUN ("signal-names", Fsignal_names, Ssignal_names, 0, 0, 0, >> + doc: /* Return a list of known signal names on this system. */) >> + (void) >> +{ >> + char name[SIG2STR_MAX]; >> + Lisp_Object names = Qnil; >> + for (int i = 0; i < 255; ++i) >> + { >> + if (!sig2str (i, name)) >> + { >> + names = Fcons (build_string (name), names); >> + } >> + } >> + return names; >> +} >> + > > Shouldn't the "255" be NSIG instead? And what about systems where POSIX > signal handling doesn't really apply, such as MS Windows and MS-DOS? > In the same header that defines SIG2STR_MAX there is SIGNUM_BOUND. It is defined depending on the availability of other macros, including NSIG. Couldn't it be used instead?