From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: master 6b7ff60a5e7: Highlight the suffix in *Completions* buffer in 'basic' style too Date: Fri, 14 Jun 2024 20:04:58 +0200 Message-ID: References: <171823002031.28307.18221225159709452537@vcs2.savannah.gnu.org> <20240612220700.A0F4DC1FB4C@vcs2.savannah.gnu.org> <86h6dwf40q.fsf@mail.linkov.net> <86frtffpdb.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31758"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Dmitry Gutov To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 14 20:05:53 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sIBJ8-0007ui-1q for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jun 2024 20:05:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIBIX-0000Q7-Tk; Fri, 14 Jun 2024 14:05:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIBIS-0000Ow-Cj for emacs-devel@gnu.org; Fri, 14 Jun 2024 14:05:09 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIBIO-0003vV-O8 for emacs-devel@gnu.org; Fri, 14 Jun 2024 14:05:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1718388300; bh=qzha/7bxJnBl6zYivhIwUp2/R3w3uysfCLaIiqre91g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=aFND8mvUslnz7CupdK0uBsrKcXigBC4rHFzq7LdAQnIdG5+ZxkqWdlaEwf49YnXLZ T1+Enlsbhxk5vnW2Pu1qKTDdpmAkSjfVtoeemv5YhU5Ne2+YmbpctuWOSi+GUSCSp3 vPk7sSsDt9STkB7tpHRx7V+ok2dnYDw9pnBKLZAvaJNul5+Yc9+vdT6UIHaX/ymaV7 t27OoGOBB1GlDtYpoQ5m3Drx748tu0c8SI/97q071DCpk9JfBetRBjtVe+5pRncvE5 1yAn3jzOCm9chUxEh9yc0VASrBK9V/eHIwAO1MXNf0EzD53/c0zS7Qm624KSLinKwP ActFL3tH9wO/g== In-Reply-To: <86frtffpdb.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 14 Jun 2024 19:41:52 +0300") Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320083 Archived-At: Juri Linkov writes: >>> Lisp error: (wrong-type-argument number-or-marker-p nil) >> >> Hmm that's quite curious... I can reproduce it also without my change >> in 56537ab0228, FWIW. AFAICT the issue is that icomplete trims the >> prefix from completion candidates before passing them to >> completion-lazy-hilit, while completion--hilit-from-re expects the full >> candidate (prefix included). I'm not deeply familiar with icomplete, >> but maybe calling completion-lazy-hilit before trimming the candidates >> as in the diff below should do the trick? > > Thanks, I confirm with this change icomplete doesn't fail anymore. Thanks for confirming, pushed to master as commit 3b07d330591. Eshel