From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Newsgroups: gmane.emacs.devel Subject: Re: All platforms fail with Unicode in menus. Date: 28 Aug 2004 17:38:23 -0400 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <412E2C34.8070905@swipnet.se> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1093729135 14990 80.91.224.253 (28 Aug 2004 21:38:55 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 28 Aug 2004 21:38:55 +0000 (UTC) Cc: "Jan D." , reiner.steib@gmx.de, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 28 23:38:48 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1C1AuO-0004ZL-00 for ; Sat, 28 Aug 2004 23:38:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C1Az8-000444-11 for ged-emacs-devel@m.gmane.org; Sat, 28 Aug 2004 17:43:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1C1Ayw-00040g-LO for emacs-devel@gnu.org; Sat, 28 Aug 2004 17:43:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1C1Ayu-0003zx-Jr for emacs-devel@gnu.org; Sat, 28 Aug 2004 17:43:29 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C1Ayu-0003zn-Hc for emacs-devel@gnu.org; Sat, 28 Aug 2004 17:43:28 -0400 Original-Received: from [206.47.199.164] (helo=simmts6-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1C1Au3-0005dT-74; Sat, 28 Aug 2004 17:38:27 -0400 Original-Received: from empanada-wifi.home ([67.68.218.80]) by simmts6-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20040828213811.TAGV1635.simmts6-srv.bellnexxia.net@empanada-wifi.home>; Sat, 28 Aug 2004 17:38:11 -0400 Original-Received: by empanada-wifi.home (Postfix, from userid 502) id 8D4C02B0C74; Sat, 28 Aug 2004 17:38:23 -0400 (EDT) Original-To: David Kastrup In-Reply-To: Original-Lines: 15 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:26596 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:26596 >> + inhibit_garbage_collection (); >> Can someone that knows ENCODE_UTF_8 and garbage collection well >> comment on this patch? > I don't know either well, but of course that is not the correct way to > fix it. The correct way would be to add appropriate GCPRO and UNGCPRO > calls for temporary data structures that should not yet be collected. On what system is that, and how is it compiled. The thing is that GCPROs are almost never used nowadays: on most systems we just conservatively scan the stack. So unless his config happens to not do the conservative stack scan (and thus use the GCPROs instead), adding GCPROs won't do a thing. Stefan