From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Newsgroups: gmane.emacs.devel Subject: *Group* incorrectly popping up in a new frame Date: Tue, 16 Nov 2004 01:18:48 -0500 Message-ID: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1100585960 30023 80.91.229.6 (16 Nov 2004 06:19:20 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 16 Nov 2004 06:19:20 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 16 07:19:09 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CTwgH-0003g6-00 for ; Tue, 16 Nov 2004 07:19:09 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CTwp1-0003cH-6Q for ged-emacs-devel@m.gmane.org; Tue, 16 Nov 2004 01:28:11 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CTwou-0003bY-T4 for emacs-devel@gnu.org; Tue, 16 Nov 2004 01:28:04 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CTwou-0003b0-7t for emacs-devel@gnu.org; Tue, 16 Nov 2004 01:28:04 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CTwou-0003ap-42 for emacs-devel@gnu.org; Tue, 16 Nov 2004 01:28:04 -0500 Original-Received: from [206.47.199.165] (helo=simmts7-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CTwfy-0004GO-3G for emacs-devel@gnu.org; Tue, 16 Nov 2004 01:18:50 -0500 Original-Received: from empanada.home ([70.48.82.50]) by simmts7-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20041116061849.FXFG1621.simmts7-srv.bellnexxia.net@empanada.home>; Tue, 16 Nov 2004 01:18:49 -0500 Original-Received: by empanada.home (Postfix, from userid 502) id 4452C36E77E; Tue, 16 Nov 2004 01:18:49 -0500 (EST) Original-To: emacs-devel@gnu.org, bugs@gnus.org User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (darwin) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29909 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29909 My *Group* buffer sometimes pops up in a new frame (I use Gnus within a single frame, but I have set pop-up-frames and special-display-buffer-names to get lots of pop up frames otherwise). It turns out it's because of a suspicious call to pop-to-buffer in gnus-summary-exit. So I suggest the patch below. I also included a patch to gnus-win.el which removes redundant code (at least, my reading of code makes those 3 lines redundant since the same swith-to-buffer-or-set-buffer will happen immediately afterwards anyway). This code looks a bit too tricky for me to be 100% confident and install the patch directly in Emacs's CVS repository, so please double check it for me, thank you, Stefan --- orig/lisp/gnus/gnus-sum.el +++ mod/lisp/gnus/gnus-sum.el @@ -6677,15 +6677,12 @@ (when (eq mode 'gnus-summary-mode) (gnus-kill-buffer buf))) (setq gnus-current-select-method gnus-select-method) - (if leave-hidden - (set-buffer gnus-group-buffer) - (pop-to-buffer gnus-group-buffer)) - (if (not quit-config) - (progn - (goto-char group-point) - (unless leave-hidden - (gnus-configure-windows 'group 'force))) - (gnus-handle-ephemeral-exit quit-config)) + (set-buffer gnus-group-buffer) + (if quit-config + (gnus-handle-ephemeral-exit quit-config) + (goto-char group-point) + (unless leave-hidden + (gnus-configure-windows 'group 'force))) ;; Clear the current group name. (unless quit-config (setq gnus-newsgroup-name nil))))) --- orig/lisp/gnus/gnus-win.el +++ mod/lisp/gnus/gnus-win.el @@ -1,5 +1,5 @@ ;;; gnus-win.el --- window configuration functions for Gnus -;; Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003 +;; Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004 ;; Free Software Foundation, Inc. ;; Author: Lars Magne Ingebrigtsen @@ -457,10 +457,7 @@ ;; on all frames. (gnus-delete-windows-in-gnusey-frames)) ;; Just remove some windows. - (gnus-remove-some-windows) - (if (featurep 'xemacs) - (switch-to-buffer nntp-server-buffer) - (set-buffer nntp-server-buffer))) + (gnus-remove-some-windows)) (select-frame frame))) (let (gnus-window-frame-focus)